[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    Re: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/demuxers demux_elem.c,1.82,1.8
From:       tmattern () noos ! fr
Date:       2004-05-14 14:34:10
Message-ID: mnet5.1084545201.12738.tmattern () noos ! fr
[Download RAW message or body]




----Message d'origine----
>De: Bastien Nocera <hadess@hadess.net>
>A: Michael Roitzsch <mroi@users.sourceforge.net>
>Copie ŕ: xine-devel <xine-devel@lists.sourceforge.net>
>Sujet: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/demuxers demux_elem.c,1.82,1.83
>Date: Fri, 14 May 2004 14:54:48 +0100
>
>On Fri, 2004-05-14 at 06:31 -0700, Michael Roitzsch wrote:
>> Update of /cvsroot/xine/xine-lib/src/demuxers
>> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29179
>> 
>> Modified Files:
>> 	demux_elem.c 
>> Log Message:
>> trying to fix overly enthusiastic elem demuxer
>> 
>> 
>> Index: demux_elem.c
>> ===================================================================
>> RCS file: /cvsroot/xine/xine-lib/src/demuxers/demux_elem.c,v
>> retrieving revision 1.82
>> retrieving revision 1.83
>> diff -u -r1.82 -r1.83
>> --- demux_elem.c	10 May 2004 11:24:28 -0000	1.82
>> +++ demux_elem.c	14 May 2004 13:31:49 -0000	1.83
>> @@ -204,10 +204,13 @@
>>      for (i = 0; i < read - 4; i++) {
>>        lprintf ("%02x %02x %02x %02x\n", scratch[i], scratch[i+1], scratch[i+2], scratch[i+3]);
>>  
>> -      if (!scratch[i] && !scratch[i+1] && (scratch[i+2] == 0x01) && (scratch[i+3] == 0xb3)) {
>> -         found = 1;
>> -	 lprintf ("found header at offset 0x%x\n", i);
>> -	 break;
>> +      if ((scratch[i] == 0x00) && (scratch[i+1] == 0x00) && (scratch[i+2] == 0x01)) {
>> +	if (scratch[i+3] == 0xb3) {
>> +	  found = 1;
>> +	  lprintf ("found header at offset 0x%x\n", i);
>> +	  break;
>> +	} else
>> +	  return NULL;
>>        }
>>      }
>
>I don't quote understand the difference here...

the diff is here:
+	} else
+	  return NULL;

which means : "if the first start code is not a sequence then return NULL"
there can still be false positives, and it should discard some of your mpeg-es streams.

we really need the priority or probability stuff.

>---
>Bastien Nocera <hadess@hadess.net> 
>The little boat gently drifted across the pond exactly the way a bowling
>ball wouldn't. 

Thibaut



-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id%62&alloc_ida84&opĚk
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel

[prev in list] [next in list] [prev in thread] [next in thread]