[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    Re: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/libspucc cc_decoder.c,1.22,1.23
From:       Christian Vogler <cvogler () gradient ! cis ! upenn ! edu>
Date:       2003-12-03 21:23:10
[Download RAW message or body]

Hi Frantisek,

On Wed, Dec 03, 2003 at 09:20:14PM +0100, Frantisek Dvorak wrote:
> > >From a point of readability, the explicit "iso-8859-1" looks clearer
> > to me, but if we put this in a comment, then there is not too much of
> > a difference. I'd expect the default conversion to be a tiny bit
> > faster, but hardly relevant in the overall scheme of things.
> >
>
> iconv_open() can fail...

wouldn't the code fall back to the no-conversion behavior then? At
least, this is how I read it.

Regards
- Christian


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel
[prev in list] [next in list] [prev in thread] [next in thread]