[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    Re: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/libspucc cc_decoder.c,1.22,1.23
From:       Christian Vogler <cvogler () gradient ! cis ! upenn ! edu>
Date:       2003-12-03 19:22:38
[Download RAW message or body]

Hi Frantisek,

On Wed, Dec 03, 2003 at 07:22:32PM +0100, Frantisek Dvorak wrote:
> I tested current code really doesn't work with characters >127 how
> expected and tested your fix will help.

ah, great! That was a quick resolution.

> So now there are too possibilities for cc_decoder:
>   1) revert the last change in cc_decoder 
>       (+maybe add comments about encoding "iso-8859-1")
>   2) leave current code and let to do conversion

From a point of readability, the explicit "iso-8859-1" looks clearer
to me, but if we put this in a comment, then there is not too much of
a difference. I'd expect the default conversion to be a tiny bit
faster, but hardly relevant in the overall scheme of things.

However, I'm a bit leery of implicitly assumed defaults in general. I
think that using iso-8859-1 minimizes the chance of unintentional
future breakage, because the only way I can see this break is if the
entire character encoding scheme breaks, and this would be unlikely to
slip through the cracks.

So, unless there are serious performance concerns, I vote for keeping
the change in the CC decoder.

Regards
- Christian



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel
[prev in list] [next in list] [prev in thread] [next in thread]