[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    Re: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/liba52 xine_decoder.c,1.61,1.62
From:       Michael Roitzsch <mroi () users ! sourceforge ! net>
Date:       2003-11-18 15:48:49
[Download RAW message or body]

Hi James,

> > Replace this:
> >
> >   /* FIXME: the code here does not match the explanation above */
> >   if (buf->pts) {
> >     int32_t info;
> >     info = buf->decoder_info[1];
> >     this->pts = buf->pts;
> >     this->pts_list[this->pts_list_position]=buf->pts;
> >     this->pts_list_position++;
> >     if( this->pts_list_position > 3 )
> >       this->pts_list_position = 3;
> >     if (info == 2) {
> >       this->pts_list[this->pts_list_position]=0;
> >       this->pts_list_position++;
> >       if( this->pts_list_position > 3 )
> >         this->pts_list_position = 3;
> >     }
> >   }
> >
> > with this:
> >
> >   pts = buf->pts;
> >   for (i = buf->decoder_info[1]; i > 0; i--) {
> >     if (this->pts_list_position < 5)
> >       this->pts_list[this->pts_list_position++] = pts;
> >     else
> >       XINE_ASSERT(0, "PTS fifo overflow");
> >     pts = 0;
> >   }
> >
> > Does this look correct?
>
> Hum? Both versions of code do the same thing, so what exactly is the
> reason to change it? Or have I missed something, and your code it
> doing something differently?

They are doing the same, if buf->pts is guaranteed never to be zero and 
if buf->decoder_info[1] is always either 1 or 2. My code does not need 
these assumptions.

It's still the fact that I had a lot more passthrough dropouts with the 
new code than with the old one.

Michael

-- 
panic("Aarggh: attempting to free lock with active wait queue - shoot
 Andy");
	2.0.38 /usr/src/linux/fs/locks.c



-------------------------------------------------------
This SF. Net email is sponsored by: GoToMyPC
GoToMyPC is the fast, easy and secure way to access your computer from
any Web browser or wireless device. Click here to Try it Free!
https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel
[prev in list] [next in list] [prev in thread] [next in thread]