[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    Re: [xine-devel] BUF_FLAG_SPECIAL
From:       Ewald Snel <ewald () rambo ! its ! tudelft ! nl>
Date:       2002-12-20 11:25:57
[Download RAW message or body]

Hi Miguel,

[...]

> > The decoder_info[] array is currently only 4 bytes in size, which is far
> > too little to be able to hold 'stsd' atoms or a color palette. Perhaps we
> > should leave it as it is, where some BUF_FLAG_SPECIAL packets store data
> > in buf->content, and fix audio or video decoders where needed.
>
> Ewald, check it again. we can put pointers to data there, several other
> special buf flags do that (BUF_SPECIAL_PALETTE,
> BUF_SPECIAL_IDCIN_HUFFMAN_TABLE, BUF_SPECIAL_DECODER_CONFIG, etc)

Sorry, I didn't notice that. You're right. :)

The following packets should be fixed in the QuickTime demuxer.
- demux_qt.c:2068 :  buf->content is overwritten with pointer (is this safe?)
- demux_qt.c:2103 :   idem
- demux_qt.c:2089 :  buf->content contains 'stsd' atom (move to decode_info[])
- demux_qt.c:2123 :  idem

> regards,
>
> Miguel

Thanks.
bye,

ewald



-------------------------------------------------------
This SF.NET email is sponsored by:  The Best Geek Holiday Gifts!
Time is running out!  Thinkgeek.com has the coolest gifts for
your favorite geek.   Let your fingers do the typing.   Visit Now.
T H I N K G E E K . C O M        http://www.thinkgeek.com/sf/
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel
[prev in list] [next in list] [prev in thread] [next in thread]