[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-cvslog
Subject:    Re: [xine-cvs] CVS: xine-lib/src/libmpeg2 idct_altivec.c,1.6,1.7
From:       Mike Melanson <mike () multimedia ! cx>
Date:       2006-05-22 17:07:38
Message-ID: 4471EFDA.9030706 () multimedia ! cx
[Download RAW message or body]

Matthias Hopf wrote:
> Update of /cvsroot/xine/xine-lib/src/libmpeg2
> In directory sc8-pr-cvs10.sourceforge.net:/tmp/cvs-serv22134/src/libmpeg2
> 
> Modified Files:
> 	idct_altivec.c 
> Log Message:
> Fixed undefined symbol [SUSE #173413] (Andreas Schwab).
> 
> 
> Index: idct_altivec.c
> ===================================================================
> RCS file: /cvsroot/xine/xine-lib/src/libmpeg2/idct_altivec.c,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- idct_altivec.c	6 Nov 2004 09:23:15 -0000	1.6
> +++ idct_altivec.c	22 May 2006 17:04:35 -0000	1.7
> @@ -489,7 +489,7 @@
>  	 );
>  }
>  
> -static int16_t constants[5][8] ATTR_ALIGN(16) = {
> +static int16_t constants[5][8] ATTR_ALIGN(16) __attribute__((used)) = {
>      {23170, 13573, 6518, 21895, -23170, -21895, 32, 31},
>      {16384, 22725, 21407, 19266, 16384, 19266, 21407, 22725},
>      {22725, 31521, 29692, 26722, 22725, 26722, 29692, 31521},
> @@ -501,8 +501,6 @@
>  {
>      int i, j;
>  
> -    i = constants[0][0];	/* just pretending - keeps gcc happy */
> -
>      /* the altivec idct uses a transposed input, so we patch scan tables */
>      for (i = 0; i < 64; i++) {
>  	j = mpeg2_scan_norm[i];

Again, libmpeg2 fixes should go back into the main tree. Either that or 
we need to maintain the diff in our tree.

	Thanks...
-- 
	-Mike Melanson


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Xine-cvslog mailing list
Xine-cvslog@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-cvslog
[prev in list] [next in list] [prev in thread] [next in thread]