[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xfree86-devel
Subject:    Re: patch for linux-2.6.13-rc1
From:       Marc Aurele La France <tsi () ualberta ! ca>
Date:       2005-07-21 15:30:31
Message-ID: Pine.BSO.4.61.0507210921290.9219 () login2 ! srv ! ualberta ! ca
[Download RAW message or body]

On Fri, 1 Jul 2005, Marc Aurele La France wrote:
> On Fri, 1 Jul 2005, Jeff Chua wrote:
>> The latest linux kernel 2.6.13-rc1 modified joystick.h

>> The patch below is needed to compile using the new kernel.

>> --- xfree86/xc/programs/Xserver/hw/xfree86/input/ur98/xf86Ur-98.c.org 
>> 2005-07-01 13:50:04 +0800
>> +++ xfree86/xc/programs/Xserver/hw/xfree86/input/ur98/xf86Ur-98.c 
>> 2005-07-01 13:50:47 +0800
>> @@ -5,6 +5,8 @@
>> #include <string.h>
>> #include <errno.h>
>> #define inline __inline__
>> +#define BITS_PER_LONG 32
>> +#define __s64 long
>> #include <linux/joystick.h>
>> 
>> #undef BUS_ISA

> The #define's this adds are not portable.

> __s64 is typedef'ed by <asm/types.h>, but only when using gcc without -ansi.

> <asm/types.h> also define's BITS_PER_LONG, but only under 
> defined(__KERNEL__).

> The relevant chain here is xf86Ur-98.c #include's <sys/types.h> #include's 
> <linux/types.h> #include's <asm/types.h>.

> Therefore, I suggest you contact the author of this change to 
> <linux/joystick.h> and make him/her understand that (s)he has introduced yet 
> more userland-visible kernel header breakage.

> As to dealing with this in our sources, I'd rather wait and see what, if 
> anything, 2.6.13 final does about this.

I've explored this quite a bit more...

Starting with 2.5.62 (perhaps even earlier), you can no longer point glibc 
builds directly at header headers.  For 2.6, you are to instead use the 
alternates available at http://ep09.pld-linux.org/~mmazur/linux-libc-headers/

There's talk of fixing this breakage in 2.7.  Gobs of it, in fact.  We'll 
see...

Marc.

+----------------------------------+-----------------------------------+
|  Marc Aurele La France           |  work:   1-780-492-9310           |
|  Academic Information and        |  fax:    1-780-492-1729           |
|    Communications Technologies   |  email:  tsi@ualberta.ca          |
|  352 General Services Building   +-----------------------------------+
|  University of Alberta           |                                   |
|  Edmonton, Alberta               |     Standard disclaimers apply    |
|  T6G 2H1                         |                                   |
|  CANADA                          |                                   |
+----------------------------------+-----------------------------------+
XFree86 developer and VP.  ATI driver and X server internals.
_______________________________________________
Devel mailing list
Devel@XFree86.Org
http://XFree86.Org/mailman/listinfo/devel
[prev in list] [next in list] [prev in thread] [next in thread]