[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xfree86-devel
Subject:    Re: Imake changes in 4.5 break a couple of imake-using software packages
From:       Dejan Lesjak <dejan.lesjak () ijs ! si>
Date:       2005-06-25 23:59:45
Message-ID: 200506260159.45613.dejan.lesjak () ijs ! si
[Download RAW message or body]

On Saturday 25 of June 2005 23:03, David Dawes wrote:
> On Sat, Jun 25, 2005 at 01:33:24PM +0200, Dejan Lesjak wrote:
> >A change was made to Imake.rules rev. 3.132 that removes dependencies from
> >install targets.
>
> The rationale for this was to have everything created in the build tree
> during the build phase, allowing an install from a read-only build tree.
> Some of the install target dependencies have since been added back in
> though.

Yes, I gathered that. That is why I suggested adding those targets to all:: 
target instead of reverting this change. I completely agree with not building 
things at install stage. Unfortunately some software relied on this "bug" 
which makes this change rather incompatible for such software.

> >A couple of projects that use imake for configuring Makefiles depended on
> >imake adding dependencies to install:: target so those files were built at
> >install time. This includes at least xgammon [1], xcheckers [2], xfm [3].
> >For example in xgammon: previously imake would add XGammon.ad as
> > dependency for install target, now it fails at install like this:
> >
> >xgammon-0.98a# make install
> >/usr/bin/install -c -s  xgammon /usr/X11R6/bin/xgammon
> >/usr/bin/install -c -m 0444 XGammon.ad
> > /usr/X11R6/lib/X11/app-defaults/XGammon install: XGammon.ad: No such file
> > or directory
> >*** Error code 71
> >
> >This is handled by InstallAppDefaults macro which in turn uses
> >InstallNamedTarget from Imake.rules.
> >One solution would be to instead add such dependencies to all:: target so
> > they are still not built at install stage, which would seem to be in
> > accordance to made Imake.rules change.
>
> I would modify the Imakefiles to add an AllTarget() for such files.

Sure. I was rather wondering if previous behaviour was intentional or if 
Imakefiles from mentioned projects were misusing this. Listing what needs to 
be built explicitly in Imakefiles seems clearer though in any case. So I'll 
probably bother maintainers of those projects :)
Thanks for explanation!


Dejan
_______________________________________________
Devel mailing list
Devel@XFree86.Org
http://XFree86.Org/mailman/listinfo/devel
[prev in list] [next in list] [prev in thread] [next in thread]