[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xerces-cvs
Subject:    svn commit: r778248 - in /xerces/java/trunk/samples:
From:       mrglavas () apache ! org
Date:       2009-05-24 22:39:36
Message-ID: 20090524223937.2E7732388873 () eris ! apache ! org
[Download RAW message or body]

Author: mrglavas
Date: Sun May 24 22:39:36 2009
New Revision: 778248

URL: http://svn.apache.org/viewvc?rev=778248&view=rev
Log:
Minor performance improvement. String.length() == 0 tends to be slightly faster than \
String.equals("").

Modified:
    xerces/java/trunk/samples/dom/traversal/IteratorView.java
    xerces/java/trunk/samples/dom/traversal/TreeWalkerView.java
    xerces/java/trunk/samples/ui/TreeView.java
    xerces/java/trunk/samples/xni/PSVIWriter.java

Modified: xerces/java/trunk/samples/dom/traversal/IteratorView.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/samples/dom/traversal/IteratorView.java?rev=778248&r1=778247&r2=778248&view=diff
 ==============================================================================
--- xerces/java/trunk/samples/dom/traversal/IteratorView.java (original)
+++ xerces/java/trunk/samples/dom/traversal/IteratorView.java Sun May 24 22:39:36 \
2009 @@ -338,7 +338,7 @@
             if (nameNodeFilter==null) {
                 nameNodeFilter = new NameNodeFilter();
             }
-            if (nameText.equals("")) {
+            if (nameText.length() == 0) {
                 setMessage("NodeNameFilter name is \"\". Assuming null.");
                 nameText = null;
             }

Modified: xerces/java/trunk/samples/dom/traversal/TreeWalkerView.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/samples/dom/traversal/TreeWalkerView.java?rev=778248&r1=778247&r2=778248&view=diff
 ==============================================================================
--- xerces/java/trunk/samples/dom/traversal/TreeWalkerView.java (original)
+++ xerces/java/trunk/samples/dom/traversal/TreeWalkerView.java Sun May 24 22:39:36 \
2009 @@ -400,7 +400,7 @@
             if (nameNodeFilter==null) {
                 nameNodeFilter = new NameNodeFilter();
             }
-            if (nameText.equals("")) {
+            if (nameText.length() == 0) {
                 setMessage("NodeNameFilter name is \"\". Assuming null.");
                 nameText = null;
             }

Modified: xerces/java/trunk/samples/ui/TreeView.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/samples/ui/TreeView.java?rev=778248&r1=778247&r2=778248&view=diff
 ==============================================================================
--- xerces/java/trunk/samples/ui/TreeView.java (original)
+++ xerces/java/trunk/samples/ui/TreeView.java Sun May 24 22:39:36 2009
@@ -279,7 +279,7 @@
         messageText.selectAll();
         messageText.cut();
 
-        if (filename == null || filename.equals("")) {
+        if (filename == null || filename.length() == 0) {
             messageText.setForeground(Color.red);
             messageText.append("No input XML filename specified:"+filename+"\n");
             return;
@@ -330,7 +330,7 @@
     public Document getRoot(String filename) {
         if (DEBUG) System.out.println("START getRoot:"+filename);
 
-        if (filename == null || filename.equals(""))
+        if (filename == null || filename.length() == 0)
         return null;
 
         try {
@@ -360,7 +360,7 @@
     synchronized void readXMLFile(String filename, JTextArea ta) {
 
         if (DEBUG) System.out.println("START readXMLFile"+filename);
-        if (filename == null || filename.equals(""))
+        if (filename == null || filename.length() == 0)
             return;
         InputStream fis = null;
         BufferedReader dis = null;

Modified: xerces/java/trunk/samples/xni/PSVIWriter.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/samples/xni/PSVIWriter.java?rev=778248&r1=778247&r2=778248&view=diff
 ==============================================================================
--- xerces/java/trunk/samples/xni/PSVIWriter.java (original)
+++ xerces/java/trunk/samples/xni/PSVIWriter.java Sun May 24 22:39:36 2009
@@ -1982,7 +1982,7 @@
         String elementName,
         Vector attributes,
         XMLString elementValue) {
-        if (elementValue == null || elementValue.equals("")) {
+        if (elementValue == null || elementValue.length == 0) {
             if (attributes == null) {
                 attributes = new Vector();
             }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]