[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xerces-c-dev
Subject:    =?utf-8?q?=5BGitHub=5D_=5Bxerces-c=5D_rouault_commented_on_pull_request_=234?= =?utf-8?q?7=3A_=5BXER
From:       GitBox <git () apache ! org>
Date:       2022-01-25 17:06:14
Message-ID: 164313037411.29368.7983579405231464359.asfpy () gitbox ! apache ! org
[Download RAW message or body]


rouault commented on pull request #47:
URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1021224266


   > I cant see how my changes could cause a test regression, all my change does is \
delete 4 smart pointers that are not used in the code base.  
   yes, but that causes a memory leak since nobody would take care of freeing the \
declDTD object. Hence my extra changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]