[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-ppc-devel
Subject:    Re: [XenPPC] moving HYPERVISOR_grant_table_op may not be the best
From:       Jimi Xenidis <jimix () watson ! ibm ! com>
Date:       2007-01-24 2:24:19
Message-ID: 1AC4121F-7CC4-44EE-B3C0-ACF86C3642F5 () watson ! ibm ! com
[Download RAW message or body]

since those are arch/powerpc/platforms/xen specific stick the protos  
in setup.h in that directory.
That file will need some tending to later, but for now I'd just put  
it there.
-JX
On Jan 23, 2007, at 11:23 AM, Jerone Young wrote:

> So I started to move HYPERVISOR_grant_table_op from
> arch/powerpc/platforms/xen/gttab.c to hcall.c. Well this looks like it
> may not be the best idea.
>
> The reason is that it calls a static function,
> gnttab_pre_unmap_grant_ref, in gttab.c that would need to be added to
> include/xen/gnttab.h, and this would be the only needed for power.  
> Where
> folks can be a bit annoyed by. Don't know if it is the best idea to  
> move
> this now? What do think guys think.
>
> Having HYPERVISOR_grant_table_op in hcall.c would have all the
> hypercalls in one place, but would require a nice ifdef in a header  
> that
> some have been know to take issue with.
>
>
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@lists.xensource.com
> http://lists.xensource.com/xen-ppc-devel


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel
[prev in list] [next in list] [prev in thread] [next in thread]