[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-ia64-devel
Subject:    Re: [Xen-ia64-devel] add pci configuration code,
From:       Isaku Yamahata <yamahata () valinux ! co ! jp>
Date:       2008-09-29 2:58:49
Message-ID: 20080929025849.GB26025%yamahata () valinux ! co ! jp
[Download RAW message or body]

On Sat, Sep 27, 2008 at 01:40:49PM +0800, Xu, Anthony wrote:
> Add pci configuration code, which is needed by VTD
> 
> Signed-off-by; Anthony Xu < anthony.xu@intel.com >
> 
> 
> The new one, I put pci.c under arch/ia64/xen, since it only uses two functions of linux pci.c,
> I don't want to pull the whole pci.c in xen.

I see. I understood why you ended in the patch.
Hmm, looking at xen-unstable.hg/xen/arch/x86/pci.c,
Only pci_conf_read()/pci_conf_write() are different, other functions
seems same to x86's.
So please split out same functions into arch common file,
probably xen/drivers/pci/pci.c or something acceptable for Keir.
Then add pci_conf_read()/pci_conf_write() in xen/arch/ia64/xen/pci.c.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel
[prev in list] [next in list] [prev in thread] [next in thread]