[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [PATCH v6 06/20] xen/bitops: put __ffs() and ffz() into linux compatible header
From:       Oleksii <oleksii.kurochko () gmail ! com>
Date:       2024-03-29 18:23:31
Message-ID: 827d3d8ee11bd4a3c20dbee936132df231db1e73.camel () gmail ! com
[Download RAW message or body]

On Wed, 2024-03-20 at 16:42 +0100, Jan Beulich wrote:
> On 15.03.2024 19:06, Oleksii Kurochko wrote:
> > --- a/xen/lib/find-next-bit.c
> > +++ b/xen/lib/find-next-bit.c
> > @@ -9,6 +9,7 @@
> >    * 2 of the License, or (at your option) any later version.
> >    */
> >   #include <xen/bitops.h>
> > +#include <xen/linux-compat.h>
> >   
> >   #include <asm/byteorder.h>
> 
> Hmm, no, a library source would better not include this header.
> Surely
> the ffz() can be taken care of locally here?
Except that __ffs() from xen/linux-compat.h is used in find-next-bit.c,
so it seems that it is still need to include the header.

~ Oleksii

[prev in list] [next in list] [prev in thread] [next in thread]