[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    [XEN PATCH v3 3/7] x86/vPMU: address violations of MISRA C Rule 20.7
From:       Nicola Vetrini <nicola.vetrini () bugseng ! com>
Date:       2024-03-29 9:11:31
Message-ID: b7d750f92da63893e9699e2924eb12d3efa251b2.1711700095.git.nicola.vetrini () bugseng ! com
[Download RAW message or body]

MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
 xen/arch/x86/include/asm/vpmu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h
index f271f28e4a74..dae9b43dac6e 100644
--- a/xen/arch/x86/include/asm/vpmu.h
+++ b/xen/arch/x86/include/asm/vpmu.h
@@ -23,8 +23,8 @@
 #define MSR_TYPE_ARCH_CTRL          4
 
 /* Start of PMU register bank */
-#define vpmu_reg_pointer(ctxt, offset) ((void *)((uintptr_t)ctxt + \
-                                                 (uintptr_t)ctxt->offset))
+#define vpmu_reg_pointer(ctxt, offset) ((void *)((uintptr_t)(ctxt) + \
+                                                 (uintptr_t)(ctxt)->offset))
 
 /* Arch specific operations shared by all vpmus */
 struct arch_vpmu_ops {
-- 
2.34.1


[prev in list] [next in list] [prev in thread] [next in thread]