[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [PATCH v3 01/17] xen/pci: Refactor MSI code that implements MSI functionality within XEN
From:       Jan Beulich <jbeulich () suse ! com>
Date:       2021-09-30 14:22:46
Message-ID: 417ffe2a-0d79-99aa-eaaa-1d1715a3e0f3 () suse ! com
[Download RAW message or body]

On 29.09.2021 18:56, Stefano Stabellini wrote:
> On Tue, 28 Sep 2021, Rahul Singh wrote:
>> On Arm, the initial plan is to only support GICv3 ITS which doesn't
>> require us to manage the MSIs because the HW will protect against
>> spoofing. Move the code under CONFIG_HAS_PCI_MSI flag to gate the code
>> for ARM.
>>
>> No functional change intended.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Jan Beulich <jbeulich@suse.com>

Nevertheless I'd like to express that ...

>> --- a/xen/drivers/pci/Kconfig
>> +++ b/xen/drivers/pci/Kconfig
>> @@ -1,3 +1,7 @@
>>  
>>  config HAS_PCI
>>  	bool
>> +
>> +config HAS_PCI_MSI
>> +	bool
>> +	depends on HAS_PCI

... personally I think this should be "select HAS_PCI", and the then
redundant one in x86 might then want dropping.

Jan


[prev in list] [next in list] [prev in thread] [next in thread]