[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] [PATCH 6/8] x86/mm: split p2m ioreq server pages special handling into helper
From:       Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau () citrix ! com>
Date:       2019-01-31 16:58:03
Message-ID: 20190131165803.qp6x2jewpjdm5pt5 () mac
[Download RAW message or body]

On Thu, Jan 31, 2019 at 03:59:50PM +0100, Paul Durrant wrote:
> > -----Original Message-----
> > From: Roger Pau Monne [mailto:roger.pau@citrix.com]
> > Sent: 30 January 2019 10:37
> > To: xen-devel@lists.xenproject.org
> > Cc: Roger Pau Monne <roger.pau@citrix.com>; George Dunlap
> > <George.Dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>; Andrew Cooper
> > <Andrew.Cooper3@citrix.com>; Wei Liu <wei.liu2@citrix.com>; Jun Nakajima
> > <jun.nakajima@intel.com>; Kevin Tian <kevin.tian@intel.com>; Paul Durrant
> > <Paul.Durrant@citrix.com>
> > Subject: [PATCH 6/8] x86/mm: split p2m ioreq server pages special handling
> > into helper
> > @@ -627,19 +620,6 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_,
> > mfn_t mfn,
> > 
> > p2mt_old = p2m_flags_to_type(l1e_get_flags(*p2m_entry));
> > 
> > -        /*
> > -         * p2m_ioreq_server is only used for 4K pages, so
> > -         * the count is only done for level 1 entries.
> > -         */
> > -        if ( p2mt == p2m_ioreq_server )
> > -            p2m->ioreq.entry_count++;
> > -
> > -        if ( p2mt_old == p2m_ioreq_server )
> > -        {
> > -            ASSERT(p2m->ioreq.entry_count > 0);
> > -            p2m->ioreq.entry_count--;
> > -        }
> > -
> 
> Is p2m_old still used once this has gone? In my slightly out-of-date branch it \
> looks like it could be removed.

Yes it can be removed, thanks for noticing! Will fix in v2.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel


[prev in list] [next in list] [prev in thread] [next in thread]