[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] [PATCH 13/29] libxl: check for xc_domain_max_vcpus failure in libxl__build_pre
From:       Ian Campbell <Ian.Campbell () citrix ! com>
Date:       2013-10-31 21:29:54
Message-ID: 1383254994.5436.145.camel () dagon ! hellion ! org ! uk
[Download RAW message or body]

On Wed, 2013-10-30 at 20:51 +1300, Matthew Daley wrote:
> Coverity-ID: 1055047
> Signed-off-by: Matthew Daley <mattjd@gmail.com>
> ---
>  tools/libxl/libxl_dom.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 1873459..5b9fd27 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -209,7 +209,10 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
>      char *xs_domid, *con_domid;
>      int rc;
>  
> -    xc_domain_max_vcpus(ctx->xch, domid, info->max_vcpus);
> +    if (xc_domain_max_vcpus(ctx->xch, domid, info->max_vcpus) != 0) {
> +        LOG(ERROR, "Couldn't get max vcpu count");

This function is a setter, isn't it?

> +        return ERROR_FAIL;
> +    }
>  
>      /*
>       * Check if the domain has any CPU affinity. If not, try to build



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]