[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] [PATCH] xl: skip zero-size config data in list_domains_details
From:       Ian Campbell <Ian.Campbell () citrix ! com>
Date:       2013-10-31 20:56:28
Message-ID: 1383252988.5436.138.camel () dagon ! hellion ! org ! uk
[Download RAW message or body]

On Tue, 2013-10-22 at 16:52 +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] xl: skip zero-size config data in list_domains_details"):
> > When Xen cannot clean up a domain after its death, it remains visible in
> > Xen in -p-sd state. Xl list -l will still try to retrieve the config
> > file, which has been deleted at that time.
> ...
> > Yes, this leads to 'Domain name must be specified' because the config
> > data is NULL, aborting 'xl list -l'.
> 
> Aha.  Right.  I have just looked at the context (primarily, 8cde53d0)
> and you're entirely right with this change.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

I think I saw a conversation this morning where you decided you had been
mistaken somewhere, I think here (IIRC the suggestions was that xl list
and xl list -l should contain the same set of domains).

For the avoidance of confusion perhaps you should apply this and/or
whatever other patch was under discussion...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]