[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] [PATCH V3] xen/arm: UART addresses are not always aligned to a page.
From:       Ian Campbell <Ian.Campbell () citrix ! com>
Date:       2013-10-31 20:47:10
Message-ID: 1383252430.5436.135.camel () dagon ! hellion ! org ! uk
[Download RAW message or body]

On Thu, 2013-10-31 at 16:11 -0400, Jon Fraser wrote:
> On Thu, 2013-10-31 at 19:52 +0000, Ian Campbell wrote:
> > On Thu, 2013-10-31 at 15:37 -0400, Jon Fraser wrote:
> > > diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h
> > > index 5f7c529..707bbf7 100644
> > > --- a/xen/include/asm-arm/early_printk.h
> > > +++ b/xen/include/asm-arm/early_printk.h
> > > @@ -14,6 +14,16 @@
> > >  
> > >  #ifdef EARLY_PRINTK
> > >  
> > > +/* need to add the uart address offset in page to the fixmap address */
> > > +#define EARLY_UART_VIRTUAL_ADDRESS \
> > > +    (FIXMAP_ADDR(FIXMAP_CONSOLE) +(EARLY_UART_BASE_ADDRESS & ~PAGE_MASK))
> > > +
> > > +#endif
> > > +
> > > +#ifndef __ASSEMBLY__
> > > +
> > > +#ifdef EARLY_PRINTK
> > > +
> > 
> > Is there something wrong with:
> >          #ifdef EARLY_PRINT
> >         
> >         +#define EARLY_UART_VIETRUAL_ADDRESS ...
> >         +
> >         +#ifndef __ASSEMBLY__
> >         +
> >          [... existing C code...]
> >         +
> >         +#endif /* !__ASSEMBLY__ */
> >         +
> >          #endif /* EARLY_PRINTK */
> > 
> > Rather than two lots of early_printk ifdefery.
> > 
> > Ian.
> > 
> 
> The dummy functions for early_printk and early_panic
> need to be visible for not EARLY_PRINTK, but not visible
> for __ASSEMBLY__.

Ah, thanks, was missing that context from the patch, I should have
looked at the original file.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]