[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] [PATCH 0/2] enable event channel wake-up for
From:       Keir Fraser <keir.xen () gmail ! com>
Date:       2011-09-30 21:09:00
Message-ID: CAAB7DFC.22156%keir.xen () gmail ! com
[Download RAW message or body]

On 30/09/2011 13:57, "Adin Scannell" <adin@gridcentric.com> wrote:

>>>> Patch 2/2 I don't mind the principle, but the implementation is not very
>>>> scalable. I will post a rewritten version to the list. It might be early
>>>> next week before I do so.
>>> 
>>> I've attached it. Let me know how it works for you.
> 
> Seems to work for me, thanks!
> 
>> By the way my patch doesn't hook up event notification for the d->mem_share
>> structure. It doesn't look like d->mem_share.xen_port ever gets set up, and
>> your patches didn't appear to fix that either.
> 
> Yeah, it seems that is currently unused (unimplemented). I assume the
> idea was to put OOM notifications (or maybe unshare notifications) in
> that ring.
> 
> Once I hear back on the first patch, I will resend as a series (the
> event mechanism for paging requires the first patch for correctness).

You can put my sign off on the redone second patch when you re-send it:
Signed-off-by: Keir Fraser <keir@xen.org>

Also, most of the reviewers on this list prefer it if you can send patches
in-line in plain text rather than as an attachment. Makes it easier to make
detailed comments.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]