[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    [Xen-devel] Re: [PATCH][1/2] pvops-dom0: Xen acpi processor logic
From:       Jeremy Fitzhardinge <jeremy () goop ! org>
Date:       2009-11-30 20:05:39
Message-ID: 4B142593.7020801 () goop ! org
[Download RAW message or body]

On 11/26/09 18:23, Yu, Ke wrote:
> I tried making xen code modular before, the issue here is the two-way dependency \
> among acpi processor driver (driver/acpi/processor_core.c) and xen driver \
> (driver/xen/acpi_processor.c). firstly, acpi processor driver depend on xen driver \
> routine processor_cntl_xen_notify(). Secondly, if xen driver depend on some routine \
> of acpi processor driver (e.g. acpi_set_processor_driver as you mentioned), then \
> there is two way dependency between these two modules, which cannot pass \
> compilation. so what I have done in last patch is moving related code from xen part \
> to acpi processor driver part, to eliminate the xen->acpi processor dependency. 

Well, you can either make it a looser coupling by making the acpi->xen
call via a function pointer, or by using Kconfig to make sure that the
Xen code and the ACPI code are always compiled in a compatible way (ie,
both builtin or both modules).

    J


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel


[prev in list] [next in list] [prev in thread] [next in thread]