[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to
From:       Ian Jackson <Ian.Jackson () eu ! citrix ! com>
Date:       2009-04-29 15:35:24
Message-ID: 18936.29628.474866.270018 () mariner ! uk ! xensource ! com
[Download RAW message or body]

Li, Xin writes ("RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img"):
> Any comments on this patch? it's a block issue to our QA test.

Sorry to delay replying to this.

> >+    else
> >+        drv = &bdrv_raw;

This appears to reintroduce the image format vulnerability.  Are you
sure it's right ?

The effect of your patch seems to be in this case:
  * the filename does not refer to a block device
  * the format is not specified in the filename
  * the actual contents of the image is not autodetected as any
    image format (eg, qcow or qcow2)
In that case, without your patch, the open fails.  With your patch,
the file is opened with bdrv_raw.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]