[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] [PATCH] xenconsole: fix xencons=tty[0-9]+ param
From:       Keir Fraser <Keir.Fraser () cl ! cam ! ac ! uk>
Date:       2006-06-30 17:31:50
Message-ID: bfce2d286dd02343f50bfb193c7bc6f5 () cl ! cam ! ac ! uk
[Download RAW message or body]


On 30 Jun 2006, at 17:56, Mark McLoughlin wrote:

> 	If you boot with e.g. xencons=tty3, then tty1/tty2 aren't valid
> devices.
>
> 	Attached patch makes it always create valid devices on tty1-tty63, but
> all but the one specified by xencons are dummy devices.

Is your change to ttyS correct for anything other than ttyS0? Looks 
like you'd incorrectly bind on ttyS0.

Also I see you made a predicate more complicated which is repeated many 
times. Could you hide it behind a suitably named macro? You may need to 
make it more complicated still to fix ttyS case...

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]