[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    Re: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [XEN] BUG() places
From:       Keir Fraser <Keir.Fraser () cl ! cam ! ac ! uk>
Date:       2006-06-30 16:04:29
Message-ID: 643386083a641c77eec58bc2021a2d37 () cl ! cam ! ac ! uk
[Download RAW message or body]


On 30 Jun 2006, at 16:57, Jimi Xenidis wrote:

>> [XEN] BUG() places console in sync mode.
>> Also move the BUG code out of line.
>> Original patch from Jimi Xenidis.
>> diff -r 25c6ea6d4024 -r 1d17ddd9e45d xen/include/xen/lib.h
> [...]
>> +extern void __bug(char *file, int line) __attribute__((noreturn));
>
> I can understand panic() being "noreturn", which it isn't, but __bug() 
> should not, since It should result in some debugging logic (gdb, xmon, 
> whatever) that could potentially continue.

Is it used in any contexts other than where some pretty serious error 
has occurred and all you want to do is postmortem? I don't think 
continuing would ever be be helpful or sane.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
[prev in list] [next in list] [prev in thread] [next in thread]