[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-devel
Subject:    [Xen-devel] Bug in the bind_evtchn_to_xxx patch
From:       NAHieu <nahieu () gmail ! com>
Date:       2005-09-30 7:23:14
Message-ID: 5d7aca950509300023mf019702vb575e43a06f76a96 () mail ! gmail ! com
[Download RAW message or body]

Keir, looks like in the below patch you had some typos - see lines
with (###): all the "tpm"  should be "tp".

Hieu.

----
# HG changeset patch
# User kaf24@firebug.cl.cam.ac.uk
# Node ID 559ad1abb3d502079ff5bbd39e2979f0a637549e
# Parent  805ee053e61f4c25e642ff3bb9e657966a15bc33
Change semantics of bind_evtchn_to_xxx and
unbind_evtchn_from_xxx. The bind now returns the IRQ
number on success. The unbind takes this as a parameter
instead of the event-channel port. Also, unbind closes
down the underlying event-channel port if it is still
live.
<snip>
--- a/linux-2.6-xen-sparse/drivers/xen/tpmfront/tpmfront.c      Thu
Sep 29 12:05:43 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/tpmfront/tpmfront.c      Thu
Sep 29 14:14:03 2005
@@ -292,8 +292,10 @@
               free_page((unsigned long)tp->tx);
               tp->tx = NULL;
       }
-       unbind_evtchn_from_irqhandler(tp->evtchn, NULL);
-       tp->evtchn = 0;
+
+       if (tpm->irq)  (###)
+               unbind_evtchn_from_irqhandler(tp->irq, NULL);
+       tp->evtchn = tpm->irq = 0;   (###)
 }
<snip>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

[prev in list] [next in list] [prev in thread] [next in thread]