[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-cvs
Subject:    [xen master] xen/console: address violations of MISRA C:2012 Rule 8.2
From:       patchbot () xen ! org
Date:       2023-11-30 12:36:03
Message-ID: E1r8gGx-0005ZP-Nw () xenbits ! xenproject ! org
[Download RAW message or body]

commit 07551414ca68d215b4877ae044b9ab6eb4cc1b55
Author:     Federico Serafini <federico.serafini@bugseng.com>
AuthorDate: Wed Nov 29 10:03:46 2023 +0100
Commit:     Jan Beulich <jbeulich@suse.com>
CommitDate: Wed Nov 29 10:03:46 2023 +0100

    xen/console: address violations of MISRA C:2012 Rule 8.2
    
    Add missing parameter names. No functional change.
    
    Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/char/console.c | 4 ++--
 xen/include/xen/console.h  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 946af5e625..0666564ec9 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -393,9 +393,9 @@ long read_console_ring(struct xen_sysctl_readconsole *op)
 static char serial_rx_ring[SERIAL_RX_SIZE];
 static unsigned int serial_rx_cons, serial_rx_prod;
 
-static void (*serial_steal_fn)(const char *, size_t nr) = early_puts;
+static void (*serial_steal_fn)(const char *str, size_t nr) = early_puts;
 
-int console_steal(int handle, void (*fn)(const char *, size_t nr))
+int console_steal(int handle, void (*fn)(const char *str, size_t nr))
 {
     if ( (handle == -1) || (handle != sercon_handle) )
         return 0;
diff --git a/xen/include/xen/console.h b/xen/include/xen/console.h
index ab5c30c0da..68759862e8 100644
--- a/xen/include/xen/console.h
+++ b/xen/include/xen/console.h
@@ -36,7 +36,7 @@ struct domain *console_input_domain(void);
  * Steal output from the console. Returns +ve identifier, else -ve error.
  * Takes the handle of the serial line to steal, and steal callback function.
  */
-int console_steal(int handle, void (*fn)(const char *, size_t nr));
+int console_steal(int handle, void (*fn)(const char *str, size_t nr));
 
 /* Give back stolen console. Takes the identifier returned by console_steal. */
 void console_giveback(int id);
--
generated by git-patchbot for /home/xen/git/xen.git#master

[prev in list] [next in list] [prev in thread] [next in thread]