[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-cvs
Subject:    [xen staging-4.15] EFI: don't convert memory marked for runtime use to ordinary RAM
From:       patchbot () xen ! org
Date:       2022-10-31 12:44:25
Message-ID: E1opU9R-0002du-27 () xenbits ! xenproject ! org
[Download RAW message or body]

commit b833014293f3fa5a7c48756ce0c8c9f3e4a666ff
Author:     Jan Beulich <jbeulich@suse.com>
AuthorDate: Mon Oct 31 13:33:29 2022 +0100
Commit:     Jan Beulich <jbeulich@suse.com>
CommitDate: Mon Oct 31 13:33:29 2022 +0100

    EFI: don't convert memory marked for runtime use to ordinary RAM
    
    efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
    higher priority than the type of the range. To avoid accessing memory at
    runtime which was re-used for other purposes, make
    efi_arch_process_memory_map() follow suit. While in theory the same would
    apply to EfiACPIReclaimMemory, we don't actually "reclaim" or clobber
    that memory (converted to E820_ACPI on x86) there (and it would be a bug
    if the Dom0 kernel tried to reclaim the range, bypassing Xen's memory
    management, plus it would be at least bogus if it clobbered that space),
    hence that type's handling can be left alone.
    
    Fixes: bf6501a62e80 ("x86-64: EFI boot code")
    Fixes: facac0af87ef ("x86-64: EFI runtime code")
    Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    master commit: f324300c8347b6aa6f9c0b18e0a90bbf44011a9a
    master date: 2022-10-21 12:30:24 +0200
---
 xen/arch/arm/efi/efi-boot.h | 3 ++-
 xen/arch/x86/efi/efi-boot.h | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index cf9c37153f..37d7ebd59a 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -149,7 +149,8 @@ static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *
 
     for ( Index = 0; Index < (mmap_size / desc_size); Index++ )
     {
-        if ( desc_ptr->Attribute & EFI_MEMORY_WB &&
+        if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
+             (desc_ptr->Attribute & EFI_MEMORY_WB) &&
              (desc_ptr->Type == EfiConventionalMemory ||
               desc_ptr->Type == EfiLoaderCode ||
               desc_ptr->Type == EfiLoaderData ||
diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index 84fd779314..3c3b3ab936 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -183,7 +183,9 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable,
             /* fall through */
         case EfiLoaderCode:
         case EfiLoaderData:
-            if ( desc->Attribute & EFI_MEMORY_WB )
+            if ( desc->Attribute & EFI_MEMORY_RUNTIME )
+                type = E820_RESERVED;
+            else if ( desc->Attribute & EFI_MEMORY_WB )
                 type = E820_RAM;
             else
         case EfiUnusableMemory:
--
generated by git-patchbot for /home/xen/git/xen.git#staging-4.15

[prev in list] [next in list] [prev in thread] [next in thread]