[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xen-cvs
Subject:    [Xen-changelog] [xen master] tools/xl: fix segfault in xl migrate --debug
From:       patchbot () xen ! org
Date:       2014-12-21 3:23:15
Message-ID: E1Y2X6x-000717-IM () xenbits ! xen ! org
[Download RAW message or body]

commit 36174af3fbeb1b662c0eadbfa193e77f68cc955b
Author:     M A Young <m.a.young@durham.ac.uk>
AuthorDate: Thu Dec 18 10:02:16 2014 +0000
Commit:     Ian Campbell <ian.campbell@citrix.com>
CommitDate: Thu Dec 18 10:02:16 2014 +0000

    tools/xl: fix segfault in xl migrate --debug
    
    If differences are found during the verification phase of xl migrate
    --debug then it is likely to crash with a segfault because the bogus
    pagebuf->pfn_types[pfn] is used in a print statement instead of
    pfn_type[pfn] .
    
    Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
 tools/libxc/xc_domain_restore.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/libxc/xc_domain_restore.c b/tools/libxc/xc_domain_restore.c
index d8bd9b3..a382701 100644
--- a/tools/libxc/xc_domain_restore.c
+++ b/tools/libxc/xc_domain_restore.c
@@ -1404,7 +1404,7 @@ static int apply_batch(xc_interface *xch, uint32_t dom, struct restore_ctx *ctx,
                 int v;
 
                 DPRINTF("************** pfn=%lx type=%lx gotcs=%08lx "
-                        "actualcs=%08lx\n", pfn, pagebuf->pfn_types[pfn],
+                        "actualcs=%08lx\n", pfn, pfn_type[pfn],
                         csum_page(region_base + i * PAGE_SIZE),
                         csum_page(buf));
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xen.org
http://lists.xensource.com/xen-changelog
[prev in list] [next in list] [prev in thread] [next in thread]