[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xalan-dev
Subject:    [jira] Commented: (XALANJ-2206) [PATCH] Propagate template inlining
From:       "Brian Minchau (JIRA)" <xalan-dev () xml ! apache ! org>
Date:       2007-09-19 20:58:12
Message-ID: 11696515.1190235492926.JavaMail.jira () brutus
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/XALANJ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528894 \
] 

Brian Minchau commented on XALANJ-2206:
---------------------------------------

Actually Yash punted the problem to another committer, but the ball bounced off them \
and I'm catching it before it falls on the ground.

I have some review comments on the patch so far:

Basically good so far.

Curious that the patch gets rid of a few new Boolean(true) sort of things and \
replaces them  with Boolean.TRUE, which is a good thing, ... but then the patch goes \
on to add this in TransformerFactoryImpl:  return new Boolean(_enableInling)
rather than this:
      if (_enableInlining)
         return Boolean.TRUE;
     else
         return Boolean.FALSE;

Minor stuff over all.  A bit more review of mine needed before I approve/commit a \
slightly modified version of the patch.

> [PATCH] Propagate template inlining trax attribute
> --------------------------------------------------
> 
> Key: XALANJ-2206
> URL: https://issues.apache.org/jira/browse/XALANJ-2206
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Environment: trax, command line is not affected
> Reporter: Vadim Gritsenko
> Assignee: Brian Minchau
> Attachments: inlining-patch.diff
> 
> 
> Template inlining attribute set on xsltc TransformerFactoryImpl has no effect, \
> default value from Stylesheet is always used. Attached patch resolves this issue. \
> This is required in order to use large stylesheets (such as where applyTemplates \
> method with template inlining is over 64Kb).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]