[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wsf-javascript-dev
Subject:    [Dev] Notes from Code Review - HL7 Message Interceptor/Publisher
From:       Malith Dhanushka <malith () wso2 ! com>
Date:       2013-12-20 15:17:21
Message-ID: CAE1HwRei+XH23C0ZFLEZ43U_Y_JYe_NeVZM7D6NX+6rz6CtjwA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi folks,

Following changes are discussed to be done in the code review.

1. Wrap code added to initMessage method to another method

2. Remove class which created for Stream definition related info and add
constants for that

3. Throw an exception if Stream Definition instance creation fails

4. Convert utility methods to static blocks in StreamDefUtil class

5. Re factor Async and Loadbalancer Data publishers

6. Break down long methods in publisher class

7. Avoid appending data type names when creating keys from HL7 message

8. Add another parameter to provide secure url for BAM connection

9. Implement a way to publish fault HL7 messages (Keep a flag)

Thanks,
Malith
-- 
Malith Dhanushka
Engineer - Data Technologies
*WSO2, Inc. : wso2.com <http://wso2.com/>*
*Mobile*          : +94 716 506 693

[Attachment #5 (text/html)]

<div dir="ltr"><div>Hi folks,</div><div><br></div><div>Following changes are \
discussed to be done in the code review.</div><div><br></div><div><div>1. Wrap code \
added to initMessage method to another method</div><div><br></div> <div>2. Remove \
class which created for Stream definition related info and add constants for \
that</div><div><br></div><div>3. Throw an exception if Stream Definition instance \
creation fails</div><div><br></div><div>4. Convert utility methods to static blocks \
in StreamDefUtil class</div> <div><br></div><div>5. Re factor Async and Loadbalancer \
Data publishers</div><div><br></div><div>6. Break down long methods in publisher \
class</div><div><br></div><div>7. Avoid appending data type names when creating keys \
from HL7 message</div> <div><br></div><div>8. Add another parameter to provide secure \
url for BAM connection</div></div><div><br></div><div style>9. Implement a way to \
publish fault HL7 messages (Keep a flag)</div><div><br></div><div style>Thanks,</div> \
<div style>Malith</div>-- <br><div dir="ltr"><span \
style="color:rgb(153,153,153)"><font face="arial, sans-serif">Malith \
Dhanushka</font></span><br><font size="1"><span style="color:rgb(153,153,153)"><font \
face="trebuchet ms,sans-serif">Engineer</font><font face="trebuchet ms,sans-serif"> - \
Data Technologies<br> </font></span></font><div \
style="font-family:arial,sans-serif;background-color:rgb(255,255,255)"><div><font \
size="1"><span style="color:rgb(153,153,153)"><font face="trebuchet \
ms,sans-serif"><b><span style="font-weight:normal">WSO2, Inc. : <a \
href="http://wso2.com/" \
target="_blank">wso2.com</a></span></b></font></span></font></div> <div><i \
style="color:rgb(153,153,153);font-size:x-small">Mobile</i><span \
style="color:rgb(153,153,153);font-size:x-small">          : +94 716 506 \
693</span><br></div></div></div> </div>



_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


[prev in list] [next in list] [prev in thread] [next in thread]