[prev in list] [next in list] [prev in thread] [next in thread]
List: wsf-java-dev
Subject: Re: [Dev] Deletion of Faulty Services Deployed via a Capp
From: Thishani Lucas <thishani () wso2 ! com>
Date: 2018-01-29 9:52:47
Message-ID: CABjVrvqdjaRS1SWSKSCowSabQ4ErE42-LimMT1zB1edxBE3-NQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Shazni,
That's the issue. To determine if it's a dataservice, again we need the
service data.
On Sat, Jan 27, 2018 at 10:56 PM, Shazni Nazeer <shazni@wso2.com> wrote:
> Hi Tishani,
>
> Isn't there a way to determine if it's a dataservice at the time of
> deletion. If you have a way, can't we special case the daataservice
> deletion without affecting other places that need archive name.
>
> On Thu, Jan 25, 2018 at 12:59 AM, Thishani Lucas <thishani@wso2.com>
> wrote:
>
>> Hi All,
>>
>> Earlier we had issues in the EI where we couldn't delete faulty services
>> and we could delete services deployed via capps. These are reported in the
>> public jiras [1] and [2] and the fixes are done respectively in [3] and
>> [4]. Now we have a scenario where we shouldn't allow deletion of faulty
>> services deployed via a capp.
>>
>> I tried to implement this by something similar to what I did in [5]
>> where, before sending the service names to be deleted, we check whether the
>> service is deployed via a capp. This worked perfectly fine with proxy
>> services. But for data services, it's throwing an error at the place where
>> service data is retrieved because for faulty data services, the service
>> name is returned as the archive name (/dataservices/name.dbs). If we fix
>> this, it would break the other places where the archive name is needed like
>> in [6]. Because of these issues, I'm putting this implementation on hold.
>>
>> Please provide your concerns about this issue.
>>
>> [1] https://wso2.org/jira/browse/ESBJAVA-4068
>> [2] https://wso2.org/jira/browse/ESBJAVA-4139
>> [3] https://github.com/wso2/carbon-deployment/pull/286
>> [4] https://github.com/wso2/carbon-deployment/pull/285
>> [5] https://github.com/wso2/carbon-deployment/blob/4.7.x/com
>> ponents/service-mgt/axis2-service-mgt/org.wso2.carbon.servic
>> e.mgt.ui/src/main/resources/web/service-mgt/delete_
>> service_groups_ajaxprocessor.jsp#L89
>> [6] https://github.com/wso2/carbon-deployment/blob/4.7.x/com
>> ponents/service-mgt/axis2-service-mgt/org.wso2.carbon.servic
>> e.mgt/src/main/java/org/wso2/carbon/service/mgt/ServiceAdmin.java#L779
>>
>> Thanks,
>> Thishani
>>
>> --
>> Regards,
>>
>> *Thishani Lucas*
>> *Software Engineer*
>> *WSO2 Lanka (Private) Limited**: http://wso2.com <http://wso2.com/>*
>> *lean.enterprise.middle-ware*
>>
>> *Tel: +94 77 2556931 <+94%2077%20255%206931> *
>>
>> *LinkedIn: https://www.linkedin.com/in/thishani-lucas/
>> <https://www.linkedin.com/in/thishani-lucas/>*
>>
>> <http://wso2.com/signature>
>>
>
>
>
> --
> Shazni Nazeer
>
> Mob : +94 777737331
> LinkedIn : http://lk.linkedin.com/in/shazninazeer
>
> Blogs :
>
> https://medium.com/@mshazninazeer
> http://shazninazeer.blogspot.com
>
> <http://wso2.com/signature>
>
--
Regards,
*Thishani Lucas*
*Software Engineer*
*WSO2 Lanka (Private) Limited**: http://wso2.com <http://wso2.com/>*
*lean.enterprise.middle-ware*
*Tel: +94 77 2556931 *
*LinkedIn: https://www.linkedin.com/in/thishani-lucas/
<https://www.linkedin.com/in/thishani-lucas/>*
<http://wso2.com/signature>
[Attachment #5 (text/html)]
<div dir="ltr">Hi Shazni,<div><br></div><div>That's the issue. To determine if \
it's a dataservice, again we need the service data. </div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 27, 2018 at 10:56 PM, \
Shazni Nazeer <span dir="ltr"><<a href="mailto:shazni@wso2.com" \
target="_blank">shazni@wso2.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hi Tishani,<div><br></div><div>Isn't there \
a way to determine if it's a dataservice at the time of deletion. If you have a \
way, can't we special case the daataservice deletion without affecting other \
places that need archive name.</div></div><div class="gmail_extra"><div><div \
class="h5"><br><div class="gmail_quote">On Thu, Jan 25, 2018 at 12:59 AM, Thishani \
Lucas <span dir="ltr"><<a href="mailto:thishani@wso2.com" \
target="_blank">thishani@wso2.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hi All,<div><br></div><div>Earlier we had \
issues in the EI where we couldn't delete faulty services and we could delete \
services deployed via capps. These are reported in the public jiras [1] and [2] and \
the fixes are done respectively in [3] and [4]. Now we have a scenario where we \
shouldn't allow deletion of faulty services deployed via a \
capp.</div><div><br></div><div>I tried to implement this by something similar to what \
I did in [5] where, before sending the service names to be deleted, we check whether \
the service is deployed via a capp. This worked perfectly fine with proxy services. \
But for data services, it's throwing an error at the place where service data is \
retrieved because for faulty data services, the service name is returned as the \
archive name (/dataservices/name.dbs). If we fix this, it would break the other \
places where the archive name is needed like in [6]. Because of these issues, I'm \
putting this implementation on hold. </div><div><br></div><div>Please provide your \
concerns about this issue.</div><div><br></div><div>[1] <a \
href="https://wso2.org/jira/browse/ESBJAVA-4068" \
target="_blank">https://wso2.org/jira/brow<wbr>se/ESBJAVA-4068</a></div><div>[2] <a \
href="https://wso2.org/jira/browse/ESBJAVA-4139" \
target="_blank">https://wso2.org/jira/brow<wbr>se/ESBJAVA-4139</a></div><div>[3] <a \
href="https://github.com/wso2/carbon-deployment/pull/286" \
target="_blank">https://github.com/wso2/ca<wbr>rbon-deployment/pull/286</a></div><div>[4] \
<a href="https://github.com/wso2/carbon-deployment/pull/285" \
target="_blank">https://github.com/wso2/ca<wbr>rbon-deployment/pull/285</a></div><div>[5] \
<a href="https://github.com/wso2/carbon-deployment/blob/4.7.x/components/service-mgt/a \
xis2-service-mgt/org.wso2.carbon.service.mgt.ui/src/main/resources/web/service-mgt/delete_service_groups_ajaxprocessor.jsp#L89" \
target="_blank">https://github.com/wso2/ca<wbr>rbon-deployment/blob/4.7.x/com<wbr>pone \
nts/service-mgt/axis2-serv<wbr>ice-mgt/org.wso2.carbon.servic<wbr>e.mgt.ui/src/main/re \
sources/<wbr>web/service-mgt/delete_<wbr>service_groups_ajaxprocessor.<wbr>jsp#L89</a></div><div>[6] \
<a href="https://github.com/wso2/carbon-deployment/blob/4.7.x/components/service-mgt/a \
xis2-service-mgt/org.wso2.carbon.service.mgt/src/main/java/org/wso2/carbon/service/mgt/ServiceAdmin.java#L779" \
target="_blank">https://github.com/wso2/ca<wbr>rbon-deployment/blob/4.7.x/com<wbr>pone \
nts/service-mgt/axis2-serv<wbr>ice-mgt/org.wso2.carbon.servic<wbr>e.mgt/src/main/java/ \
org/wso2/<wbr>carbon/service/mgt/ServiceAdmi<wbr>n.java#L779</a></div><div><br></div><div>Thanks,</div><div>Thishani</div><span \
class="m_2648782152797880660HOEnZb"><font color="#888888"><div><div><br></div>-- \
<br><div class="m_2648782152797880660m_2185348883707701824gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div \
dir="ltr"><font color="#000000">Regards,</font></div><div dir="ltr"><font \
color="#000000"><br></font><div><div><b><font color="#999999">Thishani \
Lucas</font></b></div><div><font color="#999999"><i>Software Engineer</i><b> \
</b></font></div><div><i style="color:rgb(136,136,136);font-size:12.8px"><span \
style="color:rgb(153,153,153)">WSO2 Lanka (Private) Limited</span></i><i \
style="font-size:12.8px;color:rgb(136,136,136)"><span \
style="color:rgb(153,153,153)"><font color="#888888">:</font> <a \
href="http://wso2.com/" style="color:rgb(17,85,204)" \
target="_blank">http://wso2.com</a></span></i><br></div><div><i \
style="color:rgb(136,136,136);font-size:12.8px"><span \
style="color:rgb(153,153,153)">lean.enterprise.middle-ware</span></i><b><span \
style="font-size:12.8px"><font color="#000000"><br></font></span></b></div><div><i \
style="color:rgb(136,136,136);font-size:12.8px"><span \
style="color:rgb(153,153,153)"><br></span></i></div><div><span \
style="font-size:12.8px"><font color="#999999"><i>Tel: <a \
href="tel:+94%2077%20255%206931" value="+94772556931" target="_blank">+94 77 \
2556931</a> </i></font></span></div><div><i><font color="#999999"><span \
style="font-size:12.8px">LinkedIn: </span><a \
href="https://www.linkedin.com/in/thishani-lucas/" \
target="_blank">https://www.linkedin.com/in/th<wbr>ishani-lucas/</a></font><br></i></div></div><div><br></div><div><a \
href="http://wso2.com/signature" target="_blank"><img \
src="http://c.content.wso2.com/signatures/wso2-signature-general.png"></a><br></div></div></div></div></div></div></div></div></div>
</div></font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span \
class="HOEnZb"><font color="#888888">-- <br><div \
class="m_2648782152797880660gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div \
style="font-family:verdana,sans-serif;font-size:12.8px"><span \
style="line-height:14.4444px"><a value="+94773191455"><font color="#000000">Shazni \
Nazeer</font></a></span></div><div \
style="font-family:verdana,sans-serif;font-size:12.8px"><font color="#000000"><span \
style="line-height:14.4318px"><br></span></font></div><div><div dir="ltr"><div \
dir="ltr"><div dir="ltr"><span></span><div \
style="font-family:verdana,sans-serif;color:rgb(136,136,136)"><span \
style="line-height:14.44444465637207px"><span style="color:rgb(0,0,0)">Mob :</span><a \
value="+94773191455"><font color="#888888"> <span style="color:rgb(0,0,255)"><span \
style="background-color:rgb(255,255,255)">+94 \
777737331</span></span></font><br></a></span></div><div \
style="font-family:verdana,sans-serif"><font color="#000000"><span \
style="line-height:14.431818008422852px">LinkedIn : </span></font><a \
href="http://lk.linkedin.com/in/shazninazeer" \
target="_blank">http://lk.linkedin.com/in/<wbr>shazninazeer</a></div><div \
style="font-family:verdana,sans-serif"><font color="#000000"><span \
style="line-height:14.431818008422852px"><br></span></font></div><div \
style="font-family:verdana,sans-serif"><font color="#000000"><span \
style="line-height:14.431818008422852px">Blogs : </span></font></div><div \
style="font-family:verdana,sans-serif"><font \
color="#000000"><br></font></div><div><font color="#000000"><font face="verdana, \
sans-serif"><a href="https://medium.com/@mshazninazeer" \
target="_blank">https://medium.com/@<wbr>mshazninazeer</a></font><br></font></div><div \
style="font-family:verdana,sans-serif"><font color="#000000"><span \
style="line-height:14.431818008422852px"><a href="http://shazninazeer.blogspot.com" \
target="_blank">http://shazninazeer.blogspot.<wbr>com</a></span></font></div><div \
style="font-family:verdana,sans-serif"><font color="#000000"><br></font></div><div \
style="font-family:verdana,sans-serif"><font color="#000000"><a \
href="http://wso2.com/signature" target="_blank"><img \
src="http://c.content.wso2.com/signatures/wso2-signature-general.png"></a><br></font></div></div></div></div></div></div></div></div></div></div></div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div \
dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><font \
color="#000000">Regards,</font></div><div dir="ltr"><font \
color="#000000"><br></font><div><div><b><font color="#999999">Thishani \
Lucas</font></b></div><div><font color="#999999"><i>Software Engineer</i><b> \
</b></font></div><div><i style="color:rgb(136,136,136);font-size:12.8px"><span \
style="color:rgb(153,153,153)">WSO2 Lanka (Private) Limited</span></i><i \
style="font-size:12.8px;color:rgb(136,136,136)"><span \
style="color:rgb(153,153,153)"><font color="#888888">:</font> <a \
href="http://wso2.com/" style="color:rgb(17,85,204)" \
target="_blank">http://wso2.com</a></span></i><br></div><div><i \
style="color:rgb(136,136,136);font-size:12.8px"><span \
style="color:rgb(153,153,153)">lean.enterprise.middle-ware</span></i><b><span \
style="font-size:12.8px"><font color="#000000"><br></font></span></b></div><div><i \
style="color:rgb(136,136,136);font-size:12.8px"><span \
style="color:rgb(153,153,153)"><br></span></i></div><div><span \
style="font-size:12.8px"><font color="#999999"><i>Tel: +94 77 2556931 \
</i></font></span></div><div><i><font color="#999999"><span \
style="font-size:12.8px">LinkedIn: </span><a \
href="https://www.linkedin.com/in/thishani-lucas/" \
target="_blank">https://www.linkedin.com/in/thishani-lucas/</a></font><br></i></div></div><div><br></div><div><a \
href="http://wso2.com/signature" target="_blank"><img \
src="http://c.content.wso2.com/signatures/wso2-signature-general.png"></a><br></div></div></div></div></div></div></div></div></div>
</div>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic