[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ws-general
Subject:    [jira] [Commented] (AXIOM-486) AxiomTestVerb should not extend TestVerb
From:       "Hudson (JIRA)" <jira () apache ! org>
Date:       2016-09-26 8:50:20
Message-ID: JIRA.13003449.1473311912000.661286.1474879820595 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/AXIOM-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522488#comment-15522488 \
] 

Hudson commented on AXIOM-486:
------------------------------

SUCCESS: Integrated in Jenkins build axiom-1.2.x #40 (See \
                [https://builds.apache.org/job/axiom-1.2.x/40/])
AXIOM-486: Merge r1762243 to the 1.2 branch. (veithen: rev 1762282)
* (edit) axiom
* (edit) axiom/testing
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/builder/TestCloseWithSystemId.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/builder/TestDetachWithDOM.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/builder/TestDetachWithSAXSource.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/builder/TestDetachWithStream.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/container/TestAddChildWithIncompleteSibling.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestAddAttributeReplace.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestAddAttributeReuseExistingPrefix.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestDetachWithDifferentBuilder.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestGetAllDeclaredNamespacesRemove.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestAddAttribute.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestDeclareNamespace.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestDetach.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestDiscard.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestGetAllAttributes.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestGetAllDeclaredNamespaces.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestGetAttribute.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/sourcedelement/TestGetAttributeValue.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/attr/TestSetValueOnNamespaceDeclaration.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestSetRoleWithoutExistingNamespaceDecl.java
                
* (edit) axiom/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/mtom/TestBuilderDetach.java
                
* (edit) axiom/testing/axiom-truth/src/main/java/org/apache/axiom/truth/AxiomTestVerb.java
                
* (add) axiom/testing/axiom-truth/src/main/java/org/apache/axiom/truth/AxiomTruth.java



> AxiomTestVerb should not extend TestVerb
> ----------------------------------------
> 
> Key: AXIOM-486
> URL: https://issues.apache.org/jira/browse/AXIOM-486
> Project: Axiom
> Issue Type: Improvement
> Affects Versions: 1.2.19
> Reporter: Christian Gruber
> Priority: Minor
> 
> AxiomTestVerb currently extends TestVerb, presumably to permit someone to only have \
> to statically import AxiomTestVerb.assertThat; However, TestVerb was not built for \
> extension, will be marked final in more upcoming versions of Truth, especially 1.0. \
> The fix is simple.  Extend AbstractVerb if (and only if) you need its \
> functionality, and otherwise simply statically import both AxiomTestVerb.assertThat \
> and Truth.assertThat since the overloads are not ambiguous in their type signatures \
> (and erasure). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]