[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ws-general
Subject:    [jira] [Comment Edited] (AXIOM-483) OMElementImpl.getChildrenWithName() is too restrictive and not c
From:       "Andreas Veithen (JIRA)" <jira () apache ! org>
Date:       2016-05-27 19:55:12
Message-ID: JIRA.12971500.1463742814000.319981.1464378912953 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/AXIOM-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304660#comment-15304660 \
] 

Andreas Veithen edited comment on AXIOM-483 at 5/27/16 7:54 PM:
----------------------------------------------------------------

Code relying on the legacy behavior is easy to identify because even the simplest \
unit test exercising that code would break. Of course, that doesn't work for code \
with zero test coverage (but such code should be assumed to eventually break anyway). \
If that's the case for the particular code in Axis2 you mentioned above and you have \
a scenario where that code breaks, then you should create a JIRA issue so that a unit \
test can be added to Axis2.


was (Author: veithen):
Code relying on the legacy behavior is easy to identify because even the most simple \
unit test exercising that code would break. Of course, that doesn't work for code \
with zero test coverage (but such code should be assumed to eventually break anyway). \
If that's the case for the particular code in Axis2 you mentioned above and you have \
a scenario where that code breaks, then you should create a JIRA issue so that a unit \
test can be added to Axis2.

> OMElementImpl.getChildrenWithName() is too restrictive and not compatible with \
>                 1.2.x
> ------------------------------------------------------------------------------------
>  
> Key: AXIOM-483
> URL: https://issues.apache.org/jira/browse/AXIOM-483
> Project: Axiom
> Issue Type: Bug
> Components: LLOM
> Affects Versions: 1.3.0
> Reporter: Boris Dushanov
> Priority: Critical
> Fix For: 1.3.0
> 
> 
> In 1.2.x org.apache.axiom.om.impl.llom.OMElementImpl.getChildrenWithName() contains \
> the following comment: // The getChidrenWithName method used to tolerate an empty \
> namespace // and interpret that as getting any element that matched the local
> // name.  There are custmers of axiom that have hard-coded dependencies
> // on this semantic.
> // The following code falls back to this legacy behavior only if
> // (a) elementQName has no namespace, (b) the new iterator finds no elements
> // and (c) there are children.
> This seems to be not the case in 1.3.0 and the method is now restrictive.The \
> current behavior is correct but the problem is that it's not backward compatible \
> and will lead to many issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]