[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] Wireshark does not build on Ubunty 18.04 with LZ4 (to old version?)
From: Pascal Quantin <pascal () wireshark ! org>
Date: 2021-09-07 15:15:01
Message-ID: CAGka-81EvY=sNLMYywxFuwmpCa5KoDG7oMo-Fq8mpLxb2+rATw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Anders,
Le mar. 7 sept. 2021 Ã 14:33, Anders Broman via Wireshark-dev <
wireshark-dev@wireshark.org> a écrit :
> Hi,
>
> Build fails complaining on
>
> wiretap/file_wrappers.c:199:5 error: unknown type name ‘LZ4F_dctx'
>
>
>
> As far as I understand in the older package it uses LZ4F_dctx_s
>
> Should we require a higher version of the LZ4 library?
>
Rather than requiring a higher version of LZ4 (that is also used by CQL and
Kafka dissectors), I guess we could check the LZ4 version found in
file_wrappers.c. What do you think ?
Cheers,
Pascal.
>
>
>
> Do we need something like this: (
> https://github.com/facebook/hhvm/blob/master/CMake/FindLZ4.cmake)
>
> # fb-mysql requires LZ4F_resetDecompressionContext() which was added in
> v1.8.0
>
> if (LZ4_LIBRARY)
>
> include(CheckCSourceRuns)
>
> set(CMAKE_REQUIRED_INCLUDES ${LZ4_INCLUDE_DIR})
>
> set(CMAKE_REQUIRED_LIBRARIES ${LZ4_LIBRARY})
>
> check_c_source_runs("
>
> #include <lz4.h>
>
> int main() {
>
> int good = (LZ4_VERSION_MAJOR > 1) ||
>
> ((LZ4_VERSION_MAJOR == 1) && (LZ4_VERSION_MINOR >= 8));
>
> return !good;
>
> }" LZ4_GOOD_VERSION)
>
> set(CMAKE_REQUIRED_INCLUDES)
>
> set(CMAKE_REQUIRED_LIBRARIES)
>
> endif()
>
>
>
> Best regards
>
> Anders
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives: https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@wireshark.org
> ?subject=unsubscribe
>
[Attachment #5 (text/html)]
<div dir="ltr"><div>Hi Anders,<br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">Le mar. 7 sept. 2021 Ã 14:33, Anders Broman via Wireshark-dev \
<<a href="mailto:wireshark-dev@wireshark.org">wireshark-dev@wireshark.org</a>> \
a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;" lang="SV"><div \
class="gmail-m_-6206573569803989727WordSection1"><p \
class="MsoNormal">Hi,<u></u><u></u></p><p class="MsoNormal"><span lang="EN-US">Build \
fails complaining on <u></u><u></u></span></p><p class="MsoNormal"><span \
lang="EN-US">wiretap/file_wrappers.c:199:5 error: unknown type name \
‘LZ4F_dctx'<u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-US"><u></u> \
<u></u></span></p><p class="MsoNormal"><span lang="EN-US">As far as I understand in \
the older package it uses LZ4F_dctx_s<u></u><u></u></span></p><p \
class="MsoNormal"><span lang="EN-US">Should we require a higher version of the LZ4 \
library?</span></p></div></div></blockquote><div><br></div><div>Rather than requiring \
a higher version of LZ4 (that is also used by CQL and Kafka dissectors), I guess we \
could check the LZ4 version found in file_wrappers.c. What do you think \
?</div><div><br></div><div>Cheers,<br></div><div>Pascal.</div><div><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" \
lang="SV"><div class="gmail-m_-6206573569803989727WordSection1"><p \
class="MsoNormal"><span lang="EN-US"><u></u><u></u></span></p><p \
class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p><p \
class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p><p \
class="MsoNormal"><span lang="EN-US">Do we need something like this: (<a \
href="https://github.com/facebook/hhvm/blob/master/CMake/FindLZ4.cmake" \
target="_blank">https://github.com/facebook/hhvm/blob/master/CMake/FindLZ4.cmake</a>)<u></u><u></u></span></p><table \
style="background:white none repeat scroll 0% 0%;border-collapse:collapse" \
cellspacing="0" cellpadding="0" border="0"><tbody><tr><td \
style="background:transparent none repeat scroll 0% 0%;padding:0cm 7.5pt" \
valign="top"><p class="MsoNormal" style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)" lang="EN-US"># \
fb-mysql requires LZ4F_resetDecompressionContext() which was added in \
v1.8.0<u></u><u></u></span></p></td></tr><tr><td style="width:37.5pt;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="padding:0cm 7.5pt" \
valign="top"><p class="MsoNormal" style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">if \
(LZ4_LIBRARY)<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)"> \
include(CheckCSourceRuns)<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;padding:0cm 7.5pt" width="50" valign="top" nowrap></td><td \
style="padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)" lang="EN-US"> \
set(CMAKE_REQUIRED_INCLUDES \
${LZ4_INCLUDE_DIR})<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)" lang="EN-US"> \
set(CMAKE_REQUIRED_LIBRARIES \
${LZ4_LIBRARY})<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;padding:0cm 7.5pt" width="50" valign="top" nowrap></td><td \
style="padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)" lang="EN-US"> \
</span><span style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">check_c_source_runs("<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">#include \
<lz4.h><u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;padding:0cm 7.5pt" width="50" valign="top" nowrap></td><td \
style="padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">int main() \
{<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)" lang="EN-US"> int \
good = (LZ4_VERSION_MAJOR > 1) ||<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;padding:0cm 7.5pt" width="50" valign="top" nowrap></td><td \
style="padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)" lang="EN-US"> \
</span><span style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">((LZ4_VERSION_MAJOR \
== 1) && (LZ4_VERSION_MINOR >= \
8));<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">return \
!good;<u></u><u></u></span></p></td></tr><tr><td style="width:37.5pt;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="padding:0cm 7.5pt" \
valign="top"><p class="MsoNormal" style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">}" \
LZ4_GOOD_VERSION)<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)"> \
set(CMAKE_REQUIRED_INCLUDES)<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;padding:0cm 7.5pt" width="50" valign="top" nowrap></td><td \
style="padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)"> \
set(CMAKE_REQUIRED_LIBRARIES)<u></u><u></u></span></p></td></tr><tr><td \
style="width:37.5pt;background:transparent none repeat scroll 0% 0%;padding:0cm \
7.5pt" width="50" valign="top" nowrap></td><td style="background:transparent none \
repeat scroll 0% 0%;padding:0cm 7.5pt" valign="top"><p class="MsoNormal" \
style="line-height:15pt"><span \
style="font-size:9pt;font-family:Consolas;color:rgb(36,41,47)">endif()<u></u><u></u></span></p></td></tr></tbody></table><p \
class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p><p \
class="MsoNormal"><span lang="EN-US">Best regards<u></u><u></u></span></p><p \
class="MsoNormal"><span \
lang="EN-US">Anders<u></u><u></u></span></p></div></div>___________________________________________________________________________<br>
Sent via: Wireshark-dev mailing list <<a \
href="mailto:wireshark-dev@wireshark.org" \
target="_blank">wireshark-dev@wireshark.org</a>><br>
Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/lists/wireshark-dev</a><br>
Unsubscribe: <a href="https://www.wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/mailman/options/wireshark-dev</a><br>
mailto:<a href="mailto:wireshark-dev-request@wireshark.org" \
target="_blank">wireshark-dev-request@wireshark.org</a>?subject=unsubscribe<br> \
</blockquote></div></div>
[Attachment #6 (text/plain)]
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic