[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] Trouble uploading Wireshark enhancement
From: Fulko Hew <fulko.hew () gmail ! com>
Date: 2020-10-24 4:56:46
Message-ID: CAGuV3hM=HAR-c3GxuqjEJGyjEX0xBX4OXGBfCeadsZ1sSrGu9Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Sat, Oct 24, 2020 at 12:15 AM chuck c <bubbasnmp@gmail.com> wrote:
> https://gitlab.com/wireshark/wireshark/-/merge_requests/698
>
> Fulko Hew @fulko.hew closed 2 hours ago
> Fulko Hew @fulko.hew reopened 2 hours ago
> Fulko Hew @fulko.hew closed 2 hours ago
>
> If it will let you reopen again that would be good.
>
Done, it's reopened.
> As it is now I don't think it will be seen as a pending merge.
>
> On Fri, Oct 23, 2020 at 9:17 PM Fulko Hew <fulko.hew@gmail.com> wrote:
>
>> Thanks for all the advice. I think I've gotten further.
>> I got as far as the 'press the "Submit merge request" button' step
>> and did it.
>>
>> I then saw a page that described my merge request, and added a comment
>> with an attached PCAP file to use for testing.
>>
>> At the bottom was a 'close merge request' button, so I pressed it
>> assuming that would complete my submission. I'm having my doubts,
>> Should I have left it as open? (or should I re-open it?)
>>
>>
>>
>> ___________________________________________________________________________
>> Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>> Archives: https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-request@wireshark.org
>> ?subject=unsubscribe
>
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives: https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@wireshark.org
> ?subject=unsubscribe
[Attachment #5 (text/html)]
<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:courier \
new,monospace"><br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Oct 24, 2020 at 12:15 AM chuck c <<a \
href="mailto:bubbasnmp@gmail.com">bubbasnmp@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-size:small"><a \
href="https://gitlab.com/wireshark/wireshark/-/merge_requests/698" \
target="_blank">https://gitlab.com/wireshark/wireshark/-/merge_requests/698</a><br></div><div \
style="font-size:small"><br></div><div style="font-size:small">Fulko Hew @fulko.hew \
closed 2 hours ago<br>Fulko Hew @fulko.hew reopened 2 hours ago<br>Fulko Hew \
@fulko.hew closed 2 hours ago<br></div><div style="font-size:small"><br></div><div \
style="font-size:small">If it will let you reopen again that would be \
good.</div></div></blockquote><div><br></div><div style="font-family:courier \
new,monospace" class="gmail_default">Done, it's reopened.</div><div \
style="font-family:courier new,monospace" class="gmail_default"></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:small">As it \
is now I don't think it will be seen as a pending merge.</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 23, 2020 at 9:17 PM \
Fulko Hew <<a href="mailto:fulko.hew@gmail.com" \
target="_blank">fulko.hew@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-family:"courier new",monospace">Thanks for all the advice. I \
think I've gotten further.</div><div style="font-family:"courier \
new",monospace">I got as far as the 'press the "Submit merge request" \
button' step</div><div style="font-family:"courier new",monospace">and \
did it.</div><div><br></div><div><div style="font-family:"courier \
new",monospace">I then saw a page that described my merge request, and added a \
comment</div><div style="font-family:"courier new",monospace">with an \
attached PCAP file to use for testing.</div><div style="font-family:"courier \
new",monospace"><br></div><div style="font-family:"courier \
new",monospace">At the bottom was a 'close merge request' button, so I \
pressed it</div><div style="font-family:"courier new",monospace">assuming \
that would complete my submission. I'm having my doubts,</div><div \
style="font-family:"courier new",monospace">Should I have left it as open? \
(or should I re-open it?)</div><div style="font-family:"courier \
new",monospace"><br></div><div style="font-family:"courier \
new",monospace"></div><br></div></div> \
___________________________________________________________________________<br> Sent \
via: Wireshark-dev mailing list <<a href="mailto:wireshark-dev@wireshark.org" \
target="_blank">wireshark-dev@wireshark.org</a>><br>
Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/lists/wireshark-dev</a><br>
Unsubscribe: <a href="https://www.wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/mailman/options/wireshark-dev</a><br>
mailto:<a href="mailto:wireshark-dev-request@wireshark.org" \
target="_blank">wireshark-dev-request@wireshark.org</a>?subject=unsubscribe</blockquote></div>
___________________________________________________________________________<br>
Sent via: Wireshark-dev mailing list <<a \
href="mailto:wireshark-dev@wireshark.org" \
target="_blank">wireshark-dev@wireshark.org</a>><br>
Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/lists/wireshark-dev</a><br>
Unsubscribe: <a href="https://www.wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/mailman/options/wireshark-dev</a><br>
mailto:<a href="mailto:wireshark-dev-request@wireshark.org" \
target="_blank">wireshark-dev-request@wireshark.org</a>?subject=unsubscribe</blockquote></div></div>
[Attachment #6 (text/plain)]
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic