[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] Introduction - An Outreachy 2020 Applicant
From: Dario Lombardo <lomato () gmail ! com>
Date: 2020-10-16 6:47:47
Message-ID: CAOYJJfvAih-Q+B1YZX=UNEFyHbrQ=Ji-iFTMJo-LcPR8C92xeg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I'd suggest moving forward with the sequence a/c/b. IMO this gives a
growing difficulty that allows a soft approach with the code base. If I'm
not missing anything, (a) involves adding expert infos, that is one of the
easiest tasks in wireshark. On the other hand (c) involves pytest, which I
found a bit tricky to develop myself.
On Fri, Oct 16, 2020 at 5:05 AM Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi Amanda,
>
> Amanda Shafack wrote:
>
> > Also, regarding my initial starter contribution, I chose the
> > "micro-project" titled "Avoid pipes in git related commands in test
> > scripts" (source https://bit.ly/3iZQcT2).
>
> Thanks, sounds good.
>
> > I plan to complete the micro-project and then move on to more research
> > on Git's HTTP protocol and other resources you've pointed out.
> >
> > Let me know your thoughts on this, thanks.
>
> I think that a good next step after the Git micro-project is to get to
> know wireshark --- this would involve building wireshark, finding
> something to change, and then changing it.
>
> https://gitlab.com/wireshark/wireshark/-/wikis/Development/ describes
> how to download and build wireshark. Then for something to change, I
> have a few different ideas:
>
> a. tighten the error handling in epan/dissectors/packet-git.c
> (for example, what happens when there are not exactly 4 hexdigits
> at the beginning of a pkt-line?). Git's
> Documentation/technical/protocol-common.txt describes the pkt-line
> format and Documentation/technical/pack-protocol.txt describes the
> Git transport dissected by packet-git.
>
> b. add tests for the Git dissector. test/README.test and the page it
> links to describe how wireshark's tests work
>
> c. try to parse out the service name and protocol version in
> epan/dissectors/packet-git.c. Git's
> Documentation/technical/protocol-v2.txt describes where we can find
> that information
>
> That would get us more comfortable with the wireshark codebase and
> would help prepare for fleshing out a plan for the internship.
>
> Thoughts?
>
> Sincerely,
> Jonathan
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives: https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@wireshark.org
> ?subject=unsubscribe
--
Naima is online.
[Attachment #5 (text/html)]
<div dir="ltr">I'd suggest moving forward with the sequence a/c/b. IMO this gives \
a growing difficulty that allows a soft approach with the code base. If I'm not \
missing anything, (a) involves adding expert infos, that is one of the easiest tasks \
in wireshark. On the other hand (c) involves pytest, which I found a bit tricky to \
develop myself.</div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Fri, Oct 16, 2020 at 5:05 AM Jonathan Nieder <<a \
href="mailto:jrnieder@gmail.com">jrnieder@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Amanda,<br> <br>
Amanda Shafack wrote:<br>
<br>
> Also, regarding my initial starter contribution, I chose the<br>
> "micro-project" titled "Avoid pipes in git related commands in \
test<br> > scripts" (source <a href="https://bit.ly/3iZQcT2" rel="noreferrer" \
target="_blank">https://bit.ly/3iZQcT2</a>).<br> <br>
Thanks, sounds good.<br>
<br>
> I plan to complete the micro-project and then move on to more research<br>
> on Git's HTTP protocol and other resources you've pointed out.<br>
><br>
> Let me know your thoughts on this, thanks.<br>
<br>
I think that a good next step after the Git micro-project is to get to<br>
know wireshark --- this would involve building wireshark, finding<br>
something to change, and then changing it.<br>
<br>
<a href="https://gitlab.com/wireshark/wireshark/-/wikis/Development/" \
rel="noreferrer" target="_blank">https://gitlab.com/wireshark/wireshark/-/wikis/Development/</a> \
describes<br> how to download and build wireshark. Then for something to change, \
I<br> have a few different ideas:<br>
<br>
a. tighten the error handling in epan/dissectors/packet-git.c<br>
(for example, what happens when there are not exactly 4 hexdigits<br>
at the beginning of a pkt-line?). Git's<br>
Documentation/technical/protocol-common.txt describes the pkt-line<br>
format and Documentation/technical/pack-protocol.txt describes the<br>
Git transport dissected by packet-git.<br>
<br>
b. add tests for the Git dissector. test/README.test and the page it<br>
links to describe how wireshark's tests work<br>
<br>
c. try to parse out the service name and protocol version in<br>
epan/dissectors/packet-git.c. Git's<br>
Documentation/technical/protocol-v2.txt describes where we can find<br>
that information<br>
<br>
That would get us more comfortable with the wireshark codebase and<br>
would help prepare for fleshing out a plan for the internship.<br>
<br>
Thoughts?<br>
<br>
Sincerely,<br>
Jonathan<br>
___________________________________________________________________________<br>
Sent via: Wireshark-dev mailing list <<a \
href="mailto:wireshark-dev@wireshark.org" \
target="_blank">wireshark-dev@wireshark.org</a>><br>
Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/lists/wireshark-dev</a><br>
Unsubscribe: <a href="https://www.wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/mailman/options/wireshark-dev</a><br>
mailto:<a href="mailto:wireshark-dev-request@wireshark.org" \
target="_blank">wireshark-dev-request@wireshark.org</a>?subject=unsubscribe</blockquote></div><br \
clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div \
dir="ltr"><div><pre cols="72">Naima is online.</pre></div></div></div>
[Attachment #6 (text/plain)]
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic