[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-dev
Subject:    Re: [Wireshark-dev] Question about git style
From:       Dario Lombardo <dario.lombardo.ml () gmail ! com>
Date:       2018-01-19 8:22:42
Message-ID: CAOYJJfvcLXtoofCBwVOFPF15g77yu8h51Qbqh9mEJLouWLZTnQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


OK

On Thu, Jan 18, 2018 at 7:09 PM, Jaap Keuter <jaap.keuter@xs4all.nl> wrote:

> On 07-01-18 22:36, Dario Lombardo wrote:
> > If I'm not mistaken, that is not requested. A draft change in gerrit is
> a change
> > sent to the special branch refs/drafts/master. This is a real draft, that
> > differs from a regular change for the fact that it's not visible to
> others,
> > until it gets promoted to refs/for/master. A draft change can be
> reviewed, but
> > this requires the author to manually add reviewers. A [WIP] change it's
> just a
> > regular change, where the author is informing others that the change is
> not
> > ready to merge. This is a common practice across projects and VCSes, but
> it's
> > not enforced by anything on git/gerrit. Nothing prevents a [WIP] change
> to be
> > merged. From my experience Wireshark developers do that to make the
> review
> > process easier (for instance because petri dish can't be triggered on a
> draft
> > change), allowing anyone interested in reviewing it on board.
> > Dario.
>
> Hi Dario,
>
> Maybe you can write something like this on
> https://wiki.wireshark.org/Development/SubmittingPatches to make this
> more well
> known.
>
> Thanks,
> Jaap
> ____________________________________________________________
> _______________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@wireshark.org?subject=
> unsubscribe

[Attachment #5 (text/html)]

<div dir="ltr">OK</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, \
Jan 18, 2018 at 7:09 PM, Jaap Keuter <span dir="ltr">&lt;<a \
href="mailto:jaap.keuter@xs4all.nl" \
target="_blank">jaap.keuter@xs4all.nl</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">On <a href="tel:07-01-18%2022" value="+3907011822">07-01-18 \
22</a>:36, Dario Lombardo wrote:<br> &gt; If I&#39;m not mistaken, that is not \
requested. A draft change in gerrit is a change<br> &gt; sent to the special branch \
refs/drafts/master. This is a real draft, that<br> &gt; differs from a regular change \
for the fact that it&#39;s not visible to others,<br> &gt; until it gets promoted to \
refs/for/master. A draft change can be reviewed, but<br> &gt; this requires the \
author to manually add reviewers. A [WIP] change it&#39;s just a<br> &gt; regular \
change, where the author is informing others that the change is not<br> &gt; ready to \
merge. This is a common practice across projects and VCSes, but it&#39;s<br> &gt; not \
enforced by anything on git/gerrit. Nothing prevents a [WIP] change to be<br> &gt; \
merged. From my experience Wireshark developers do that to make the review<br> &gt; \
process easier (for instance because petri dish can&#39;t be triggered on a draft<br> \
&gt; change), allowing anyone interested in reviewing it on board.<br> &gt; \
Dario.<br> <br>
Hi Dario,<br>
<br>
Maybe you can write something like this on<br>
<a href="https://wiki.wireshark.org/Development/SubmittingPatches" rel="noreferrer" \
target="_blank">https://wiki.wireshark.org/<wbr>Development/SubmittingPatches</a> to \
make this more well<br> known.<br>
<br>
Thanks,<br>
Jaap<br>
______________________________<wbr>______________________________<wbr>_______________<br>
 Sent via:      Wireshark-dev mailing list &lt;<a \
                href="mailto:wireshark-dev@wireshark.org">wireshark-dev@wireshark.org</a>&gt;<br>
                
Archives:      <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/<wbr>lists/wireshark-dev</a><br>
                
Unsubscribe: <a href="https://www.wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/<wbr>mailman/options/wireshark-dev</a><br>
  mailto:<a href="mailto:wireshark-dev-request@wireshark.org">wireshark-dev-request@<wbr>wireshark.org</a>?subject=<wbr>unsubscribe</blockquote></div><br></div>



[Attachment #6 (text/plain)]

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe

[prev in list] [next in list] [prev in thread] [next in thread]