[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] 2.5.0 release on January 16
From: Anders Broman <a.broman58 () gmail ! com>
Date: 2018-01-18 22:13:47
Message-ID: CAOpyz=yr3H0XqhehJ9mcNsTZTWYS2gfuGWbMg1p7DBJD9YY2aA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Ok,
Probably need a complete rebuild then.
Thanks
Anders
Den 18 jan. 2018 9:09 em skrev "Pascal Quantin" <pascal.quantin@gmail.com>:
Hi Anders,
2018-01-18 18:23 GMT+01:00 Anders Broman <a.broman58@gmail.com>:
>
>
> Den 17 jan. 2018 8:37 em skrev "Stig Bjørlykke" <stig@bjorlykke.org>:
>
> On Wed, Jan 17, 2018 at 2:05 AM, Gerald Combs <gerald@wireshark.org>
> wrote:
> > On 1/13/18 4:16 AM, Stig Bjørlykke wrote:
> >> - Qt: Missing string translations after source code was moved to
> >> utils/models/manager/widgets subdirectories
> >
> > Do you know what's missing? This shouldn't be too hard to fix.
>
> I haven't investigated this, but I'm thinking that the generation of
> the *.ts files should also include the source subdirectories. The
> translations was lost just after the move to separate directories.
>
>
> >> - ByteView: Hovering bytes does not highlight the field as it used to do
> >> - ByteView: Vertical white and horisontal black lines issues
> >> - ByteView: Color issue when clicking a byte multiple times
> >
> > The 2.4 byte view didn't distinguish between hovered and a locked bytes.
> > I initially tried to do so by drawing an overline+undlerline over
> hovered bytes
> > and coloring locked bytes. Change 25348 draws a full outline instead of
> an
> > overline+undlerline.
>
> The change makes this issues better. I'm still not sure about the
> "blue text on yellow background" when locked, this does not look so
> good with the macOS colour schemes. Maybe this could be changed to a
> red thicker outline? Or maybe use our "marked packet" colours? Or a
> combination.
>
> I never understood the white vertical lines, but now it seems like
> it's a bug when drawing the background colour. Have a look at the
> attached picture.
>
> When locking a byte the first time all bytes within a protocol has
> grey background colour but this grey background colour is not added on
> subsequent locks within the same protocol byte range.
>
> And selecting a byte does not expand the corresponding tree item as it
> does in 2.4.
>
>
> --
> Stig Bjørlykke
>
>
> Hi,
>
> Are anyone else seeing a problem with the expert dialog being empty?
>
I just tried with the current top of tree on my Linux machine using Qt
5.9.1 and it works fine.
BR,
Pascal.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[Attachment #5 (text/html)]
<div dir="auto">Ok,<div dir="auto">Probably need a complete rebuild then.</div><div \
dir="auto">Thanks </div><div dir="auto">Anders</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">Den 18 jan. 2018 9:09 em skrev \
"Pascal Quantin" <<a \
href="mailto:pascal.quantin@gmail.com">pascal.quantin@gmail.com</a>>:<br \
type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div dir="ltr">Hi Anders,<br><div><div \
class="gmail_extra"><br><div class="gmail_quote"><div class="elided-text">2018-01-18 \
18:23 GMT+01:00 Anders Broman <span dir="ltr"><<a \
href="mailto:a.broman58@gmail.com" \
target="_blank">a.broman58@gmail.com</a>></span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="auto"><div><br><div class="gmail_extra"><br><div \
class="gmail_quote"><div><div class="m_5950100765440517617h5">Den 17 jan. 2018 8:37 \
em skrev "Stig Bjørlykke" <<a href="mailto:stig@bjorlykke.org" \
target="_blank">stig@bjorlykke.org</a>>:<br \
type="attribution"></div></div><blockquote \
class="m_5950100765440517617m_-3700277758910818225quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div \
class="m_5950100765440517617h5"><div \
class="m_5950100765440517617m_-3700277758910818225quoted-text">On Wed, Jan 17, 2018 \
at 2:05 AM, Gerald Combs <<a href="mailto:gerald@wireshark.org" \
target="_blank">gerald@wireshark.org</a>> wrote:<br> > On 1/13/18 4:16 AM, Stig \
Bjørlykke wrote:<br> </div><div \
class="m_5950100765440517617m_-3700277758910818225quoted-text">>> - Qt: Missing \
string translations after source code was moved to<br> >> \
utils/models/manager/widgets subdirectories<br> ><br>
</div><div class="m_5950100765440517617m_-3700277758910818225quoted-text">> Do you \
know what's missing? This shouldn't be too hard to fix.<br> <br>
</div>I haven't investigated this, but I'm thinking that the generation \
of<br> the *.ts files should also include the source subdirectories. The<br>
translations was lost just after the move to separate directories.<br>
<div class="m_5950100765440517617m_-3700277758910818225quoted-text"><br>
<br>
>> - ByteView: Hovering bytes does not highlight the field as it used to do<br>
>> - ByteView: Vertical white and horisontal black lines issues<br>
>> - ByteView: Color issue when clicking a byte multiple times<br>
><br>
> The 2.4 byte view didn't distinguish between hovered and a locked bytes.<br>
> I initially tried to do so by drawing an overline+undlerline over hovered \
bytes<br> > and coloring locked bytes. Change 25348 draws a full outline instead \
of an<br> > overline+undlerline.<br>
<br>
</div>The change makes this issues better. I'm still not sure about the<br>
"blue text on yellow background" when locked, this does not look so<br>
good with the macOS colour schemes. Maybe this could be changed to a<br>
red thicker outline? Or maybe use our "marked packet" colours? Or a<br>
combination.<br>
<br>
I never understood the white vertical lines, but now it seems like<br>
it's a bug when drawing the background colour. Have a look at the<br>
attached picture.<br>
<br>
When locking a byte the first time all bytes within a protocol has<br>
grey background colour but this grey background colour is not added on<br>
subsequent locks within the same protocol byte range.<br>
<br>
And selecting a byte does not expand the corresponding tree item as it<br>
does in 2.4.<br>
<font color="#888888"><br>
<br>
--<br>
Stig Bjørlykke<br>
</font><br><br></div></div>Hi, <br></blockquote></div></div></div><div \
dir="auto">Are anyone else seeing a problem with the expert dialog being \
empty?</div></div></blockquote><div><br></div></div><div>I just tried with the \
current top of tree on my Linux machine using Qt 5.9.1 and it works \
fine.</div><div><br></div><div>BR,</div><div>Pascal.<br></div></div></div></div></div>
<br>______________________________<wbr>______________________________<wbr>_______________<br>
Sent via: Wireshark-dev mailing list <<a \
href="mailto:wireshark-dev@wireshark.org">wireshark-dev@wireshark.org</a>><br>
Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/<wbr>lists/wireshark-dev</a><br>
Unsubscribe: <a href="https://www.wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/<wbr>mailman/options/wireshark-dev</a><br>
mailto:<a href="mailto:wireshark-dev-request@wireshark.org">wireshark-dev-request@<wbr>wireshark.org</a>?subject=<wbr>unsubscribe<br></blockquote></div><br></div>
[Attachment #6 (text/plain)]
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic