[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] Petri-dish buildbot - not finding QtWidgets/QLabel
From: Alexis La Goutte <alexis.lagoutte () gmail ! com>
Date: 2015-09-23 12:38:15
Message-ID: CAHzrgZkUqoiH-_RjDtTE3jyPWtgsHg3xH14m2Lxqjy8Ddv69bQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Sep 23, 2015 at 2:27 PM, Martin Mathieson <
martin.r.mathieson@googlemail.com> wrote:
> I uploaded another patch (no 8) to just include <QLabel> and added it
> to the petri-dish (probably-doomed number 7 will run first...).
> But I still don't understand why we get away with including
> QtWidgets/QLabel in lots of other header files. Should they be
> changed too?
>
> I found only on ui_* files... autogenerated by Qt (autotools)
Regards,
> Regards,
> Martin
>
> On Wed, Sep 23, 2015 at 1:11 PM, Alexis La Goutte
> <alexis.lagoutte@gmail.com> wrote:
> > Hi Martin,
> >
> > It is because Petri Dish use Qt 4.x...
> > and we need to add only QLabel (#include <QLabel>), no need the
> QtWidgets..
> >
> > Regards,
> >
> > On Wed, Sep 23, 2015 at 1:55 PM, Martin Mathieson
> > <martin.r.mathieson@googlemail.com> wrote:
> > >
> > > Hi,
> > >
> > > This must be something simple, but I'm trying to get a first version
> > > of the new LTE MAC statistics dialog checked in
> > > (https://code.wireshark.org/review/#/c/10578/).
> > >
> > > I'm getting this error:
> > >
> > > In file included from
> > >
> > >
> /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/ui/qt/main_window_slots.cpp:113:0:
>
> > >
> > >
> /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/ui/qt/lte_mac_statistics_dialog.h:28:28:
>
> > > fatal error: QtWidgets/QLabel: No such file or directory
> > > #include <QtWidgets/QLabel>
> > >
> > > on the Ubuntu buildbot. See
> > >
> > >
> https://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/3323/steps/compile_4/logs/stdio
>
> > >
> > > QtWidgets/QLabel is included from lots of header files in ui/qt
> > > without a problem... I did try adding QtCore/QVariant first, but I am
> > > just guessing, and don't want just to add lots of random header files
> > > to make it go away. Anyone know how it really works? I am building
> > > on ubuntu x86-64 without problems using Qt 5.4.1.
> > >
> > > Thanks,
> > > Martin
> > >
> > >
> ___________________________________________________________________________
> > > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> > > Archives: https://www.wireshark.org/lists/wireshark-dev
> > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> > >
> > > mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
> >
> >
> >
> >
> ___________________________________________________________________________
> > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> > Archives: https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> > mailto:wireshark-dev-request@wireshark.org
> ?subject=unsubscribe
>
[Attachment #5 (text/html)]
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep \
23, 2015 at 2:27 PM, Martin Mathieson <span dir="ltr"><<a \
href="mailto:martin.r.mathieson@googlemail.com" \
target="_blank">martin.r.mathieson@googlemail.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">I uploaded another patch (no 8) to just include \
<QLabel> and added it<br> to the petri-dish (probably-doomed number 7 will run \
first...).<br> But I still don't understand why we get away with including<br>
QtWidgets/QLabel in lots of other header files. Should they be<br>
changed too?<br>
<br></blockquote><div>I found only on ui_* files... autogenerated by Qt \
(autotools)<br></div><div><br></div><div>Regards,<br> <br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Regards,<br>
Martin<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Sep 23, 2015 at 1:11 PM, Alexis La Goutte<br>
<<a href="mailto:alexis.lagoutte@gmail.com">alexis.lagoutte@gmail.com</a>> \
wrote:<br> > Hi Martin,<br>
><br>
> It is because Petri Dish use Qt 4.x...<br>
> and we need to add only QLabel (#include <QLabel>), no need the \
QtWidgets..<br> ><br>
> Regards,<br>
><br>
> On Wed, Sep 23, 2015 at 1:55 PM, Martin Mathieson<br>
> <<a href="mailto:martin.r.mathieson@googlemail.com">martin.r.mathieson@googlemail.com</a>> \
wrote:<br> >><br>
>> Hi,<br>
>><br>
>> This must be something simple, but I'm trying to get a first version<br>
>> of the new LTE MAC statistics dialog checked in<br>
>> (<a href="https://code.wireshark.org/review/#/c/10578/" rel="noreferrer" \
target="_blank">https://code.wireshark.org/review/#/c/10578/</a>).<br> >><br>
>> I'm getting this error:<br>
>><br>
>> In file included from<br>
>><br>
>> /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/ui/qt/main_window_slots.cpp:113:0:<br>
>><br>
>> /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/ui/qt/lte_mac_statistics_dialog.h:28:28:<br>
>> fatal error: QtWidgets/QLabel: No such file or directory<br>
>> #include <QtWidgets/QLabel><br>
>><br>
>> on the Ubuntu buildbot. See<br>
>><br>
>> <a href="https://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/3323/steps/compile_4/logs/stdio" \
rel="noreferrer" target="_blank">https://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/3323/steps/compile_4/logs/stdio</a><br>
>><br>
>> QtWidgets/QLabel is included from lots of header files in ui/qt<br>
>> without a problem... I did try adding QtCore/QVariant first, but I am<br>
>> just guessing, and don't want just to add lots of random header \
files<br> >> to make it go away. Anyone know how it really works? I am \
building<br> >> on ubuntu x86-64 without problems using Qt 5.4.1.<br>
>><br>
>> Thanks,<br>
>> Martin<br>
>><br>
>> ___________________________________________________________________________<br>
>> Sent via: Wireshark-dev mailing list <<a \
href="mailto:wireshark-dev@wireshark.org">wireshark-dev@wireshark.org</a>><br> \
>> Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/lists/wireshark-dev</a><br>
>> Unsubscribe: <a href="https://wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://wireshark.org/mailman/options/wireshark-dev</a><br>
>><br>
>> mailto:<a href="mailto:wireshark-dev-request@wireshark.org">wireshark-dev-request@wireshark.org</a>?subject=unsubscribe<br>
><br>
><br>
><br>
> ___________________________________________________________________________<br>
> Sent via: Wireshark-dev mailing list <<a \
href="mailto:wireshark-dev@wireshark.org">wireshark-dev@wireshark.org</a>><br> \
> Archives: <a href="https://www.wireshark.org/lists/wireshark-dev" \
rel="noreferrer" target="_blank">https://www.wireshark.org/lists/wireshark-dev</a><br>
> Unsubscribe: <a href="https://wireshark.org/mailman/options/wireshark-dev" \
rel="noreferrer" target="_blank">https://wireshark.org/mailman/options/wireshark-dev</a><br>
> mailto:<a \
href="mailto:wireshark-dev-request@wireshark.org">wireshark-dev-request@wireshark.org</a>?subject=unsubscribe<br>
</div></div></blockquote></div><br></div></div>
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic