[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] Make CMake reuse Makefile.common?
From: Graham Bloice <graham.bloice () trihedral ! com>
Date: 2015-03-06 15:43:04
Message-ID: CALcKHKocoybThnyeJ4+h07iKvy3xK4+Gs6e4CGntEkthwbXOSg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On 6 March 2015 at 15:31, Alexis La Goutte <alexis.lagoutte@gmail.com>
wrote:
>
>
> On Fri, Mar 6, 2015 at 4:26 PM, Graham Bloice <graham.bloice@trihedral.com
> > wrote:
>
>> On 6 March 2015 at 15:17, Peter Wu <peter@lekensteyn.nl> wrote:
>>
>>> On Tue, Mar 03, 2015 at 05:50:10PM +0100, Alexis La Goutte wrote:
>>> > On Mon, Mar 2, 2015 at 1:16 PM, Peter Wu <peter@lekensteyn.nl> wrote:
>>> >
>>> > > Hi,
>>> > >
>>> > > Recently there have been two issues due to separate copies between
>>> CMake
>>> > > and autofoo (missing ATH dissector, missing field registrations for
>>> > > plugins).
>>> > >
>>> > > The former could occur due to missing duplication from
>>> Makefile.common
>>> > > into CMakeLists.txt. The latter happens because the
>>> > > plugins/*/CMakeLists.txt are slightly different than the Makefiles
>>> (in
>>> > > terms of variable sets).
>>> > >
>>> > > Hereby I am proposing to convert Makefile.common automatically to
>>> > > CMakeLists.inc.txt, and then include that during the build process to
>>> > > set variables. The inspiration comes from cURL which too supports
>>> > > autoconf, and (as an experimental option) cmake.
>>> > >
>>> > > See this transformation macro[0] and its use[1] for an example.
>>> > >
>>> > Hi Peter,
>>> >
>>> > Need to try... but i known CMake cURL is no perfect... and there is
>>> some
>>> > plan to drop support of CMake ;-)
>>>
>>> There *was* a plan to drop CMake support if nobody cared, but since then
>>> patches have been sent to improve it (also from my side).
>>>
>> the drop of CMake support is for cURL and no Wireshark ;-)
>
>>
>>> > And also if i remember the target is only have CMake for build system
>>> (and
>>> > remove autofoo...)
>>>
>>> That would be great, but I would not rush this yet, there are still some
>>> cmake issues like
>>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10074. (other issues
>>> I have found, but for which no bug is filled: the path to xdg-open is
>>> fully expanded by cmake).
>>>
>>> How are the windows binaries currently build? Using nmake I believe?
>>>
>>>
>> As mentioned elsewhere Windows CMake is getting good now, still some
>> issues to be sorted, but I'm hopeful of getting there by SF15.
>>
> Plan a session on SF15 about fixing CMake issue stuff ? ;-)
>
>>
>
1 slide : Call Jörg
<https://code.wireshark.org/review/#/q/owner:%22J%25C3%25B6rg+Mayer%22+status:merged,n,z>
!
--
Graham Bloice
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 6 March 2015 at \
15:31, Alexis La Goutte <span dir="ltr"><<a \
href="mailto:alexis.lagoutte@gmail.com" \
target="_blank">alexis.lagoutte@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On \
Fri, Mar 6, 2015 at 4:26 PM, Graham Bloice <span dir="ltr"><<a \
href="mailto:graham.bloice@trihedral.com" \
target="_blank">graham.bloice@trihedral.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div class="gmail_extra"><div><div><div class="gmail_quote">On 6 March 2015 \
at 15:17, Peter Wu <span dir="ltr"><<a href="mailto:peter@lekensteyn.nl" \
target="_blank">peter@lekensteyn.nl</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>On \
Tue, Mar 03, 2015 at 05:50:10PM +0100, Alexis La Goutte wrote:<br> > On Mon, Mar \
2, 2015 at 1:16 PM, Peter Wu <<a href="mailto:peter@lekensteyn.nl" \
target="_blank">peter@lekensteyn.nl</a>> wrote:<br> ><br>
> > Hi,<br>
> ><br>
> > Recently there have been two issues due to separate copies between \
CMake<br> > > and autofoo (missing ATH dissector, missing field registrations \
for<br> > > plugins).<br>
> ><br>
> > The former could occur due to missing duplication from Makefile.common<br>
> > into CMakeLists.txt. The latter happens because the<br>
> > plugins/*/CMakeLists.txt are slightly different than the Makefiles (in<br>
> > terms of variable sets).<br>
> ><br>
> > Hereby I am proposing to convert Makefile.common automatically to<br>
> > CMakeLists.inc.txt, and then include that during the build process to<br>
> > set variables. The inspiration comes from cURL which too supports<br>
> > autoconf, and (as an experimental option) cmake.<br>
> ><br>
> > See this transformation macro[0] and its use[1] for an example.<br>
> ><br>
> Hi Peter,<br>
><br>
> Need to try... but i known CMake cURL is no perfect... and there is some<br>
> plan to drop support of CMake ;-)<br>
<br>
</span>There *was* a plan to drop CMake support if nobody cared, but since then<br>
patches have been sent to improve it (also from my \
side).<br></blockquote></div></div></div></div></div></blockquote></span><div>the \
drop of CMake support is for cURL and no Wireshark ;-) <br></div><span \
class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div class="gmail_extra"><div><div><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><br>
> And also if i remember the target is only have CMake for build system (and<br>
> remove autofoo...)<br>
<br>
</span>That would be great, but I would not rush this yet, there are still some<br>
cmake issues like<br>
<a href="https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10074" \
target="_blank">https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10074</a>. (other \
issues<br> I have found, but for which no bug is filled: the path to xdg-open is<br>
fully expanded by cmake).<br>
<br>
How are the windows binaries currently build? Using nmake I believe?<br>
<div><div><br></div></div></blockquote></div><br clear="all"></div></div><div>As \
mentioned elsewhere Windows CMake is getting good now, still some issues to be \
sorted, but I'm hopeful of getting there by \
SF15.</div></div></div></blockquote></span><div>Plan a session on SF15 about fixing \
CMake issue stuff ? ;-) <br></div><blockquote class="gmail_quote" style="margin:0px \
0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div class="gmail_extra"><span><font \
color="#888888"><div></div></font></span></div></div></blockquote></div></div></div><br></blockquote><div> \
</div></div><br>1 slide : Call <a class="" \
href="https://code.wireshark.org/review/#/q/owner:%22J%25C3%25B6rg+Mayer%22+status:merged,n,z" \
title="Jörg Mayer" style="text-decoration:none;font-family:'Open \
Sans','DejaVu \
Sans',Helvetica,Arial,sans-serif;font-size:12px;line-height:16.9679985046387px;white-space:nowrap;color:rgb(34,34,34)!important">Jörg</a>!<br \
clear="all"><div><br></div>-- <br><div class="gmail_signature"><div \
dir="ltr"><div>Graham Bloice</div></div></div> </div></div>
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic