[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-dev
Subject:    Re: [Wireshark-dev] rev 43413: /trunk/ui/gtk/ /trunk/ui/gtk/: main_80211_toolbar.c
From:       Pontus Fuchs <pontus.fuchs () gmail ! com>
Date:       2012-06-21 6:35:28
Message-ID: 4FE2C0B0.7010204 () gmail ! com
[Download RAW message or body]

On 2012-06-21 08:04, Joerg Mayer wrote:
> On Wed, Jun 20, 2012 at 11:13:13PM +0200, Pontus Fuchs wrote:
>> Crap. That patch was not correct. Corrected one attached.
> ...
>>> Thanks for your merge work! The attached patch is the missing piece to
>>> get it working.
> ...
>> diff --git a/Makefile.common b/Makefile.common
>> index ac50220..e52cfc3 100644
>> --- a/Makefile.common
>> +++ b/Makefile.common
>> @@ -116,6 +116,7 @@ wireshark_SOURCES =	\
>>   	recent.c	\
>>   	summary.c	\
>>   	tempfile.c	\
>> +	ws80211_utils.c	\
>>   	u3.c
> ...
>
> Why do we need to link Wireshark with this file? Access to libnl is restricted
> to dumpcap and this file is providing the libnl interface or am I wrong?

Only the channel setting is done through dumpcap as this required 
CAP_NET_ADMIN. ws80211_utils.c also contains code for querying 
interfaces for supported frequencies etc. This code does not require any 
special permissions and is called from the toolbar GUI.

Cheers,

Pontus

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]