[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-dev
Subject:    [Wireshark-dev] Proposed changes for using a hex integer to compare against single-byte range slices
From:       Gilbert Ramirez <gram () alumni ! rice ! edu>
Date:       2012-02-28 23:03:36
Message-ID: CAMUrmdmgqv4nv1wG_kJRD_OiA914nY8mS-=fsLcNO86BSwXpZA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi. I haven't committed anything to Wireshark in quite a while, so I wanted
to gently re-introduce myself into the community by requesting a code
review.

One of my colleagues at work noticed that it feels more natural to compare
a single-byte byte string against a hex integer starting with "0x" than
with just bare hex digits.

That is, instead of this:

wlan_mgt.cisco.ccx1.unknown[8] == 19

this is more natural:

wlan_mgt.cisco.ccx1.unknown[8] == 0x19

I have opened an enhancement bug at:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6882

and attached a proposed diff to allow this.

Please let me know any feedback.

Thanks,

Gilbert

[Attachment #5 (text/html)]

Hi. I haven&#39;t committed anything to Wireshark in quite a while, so I wanted to \
gently re-introduce myself into the community by requesting a code \
review.<div><br></div><div>One of my colleagues at work noticed that it feels more \
natural to compare a single-byte byte string against a hex integer starting with \
&quot;0x&quot; than with just bare hex digits.</div> <div><br></div><div>That is, \
instead of this:</div><div><br></div><div>wlan_mgt.cisco.ccx1.unknown[8] == \
19</div><div><br></div><div>this is more \
natural:</div><div><br></div><div>wlan_mgt.cisco.ccx1.unknown[8] == 0x19 \
</div><div><br></div><div>I have opened an enhancement bug at:</div><div><a \
href="https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6882">https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6882</a>
 </div><div><br></div><div>and attached a proposed diff to allow \
this.</div><div><br></div><div>Please let me know any \
feedback.</div><div><br></div><div>Thanks,</div><div><br></div><div>Gilbert</div>



___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe

[prev in list] [next in list] [prev in thread] [next in thread]