[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-dev
Subject:    [Wireshark-dev] New packet list - sorting
From:       Jakub Zawadzki <darkjames () darkjames ! ath ! cx>
Date:       2009-11-28 12:04:08
Message-ID: 20091128120408.GA22717 () darkjames ! ath ! cx
[Download RAW message or body]

Hi,

I think these two assertions, in packet_list_compare_records()
       g_assert(a->fdata->col_text[sort_id]);
       g_assert(b->fdata->col_text[sort_id]);

are not quite correct.

If you click abort while constructing columns, it'll lead to:
 ERROR:packet_list_store.c:955:packet_list_compare_records: assertion failed: \
(a->fdata->col_text[sort_id])

IMHO it should be possible to abort constructing columns - and it should not abort \
program.

By the way, it would be nice if columns only for visible_rows will be generated & \
sorted - not all of them :) \
___________________________________________________________________________ Sent via: \
                Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe


[prev in list] [next in list] [prev in thread] [next in thread]