[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-dev
Subject: Re: [Wireshark-dev] [PATCH] NDMP config_get_auth_attr_reply missing
From: "Aaron Christensen" <aaronmf () gmail ! com>
Date: 2006-06-30 7:24:32
Message-ID: cac8087b0606300024m18b5e93cle6797f172d2e903d () mail ! gmail ! com
[Download RAW message or body]
Sure. Done:
http://wiki.wireshark.org/Network_Data_Management_Protocol
A couple of images of captured packets (including one that works after the
patch) and a sample packet capture. The NDMP client/server I was using had
some extensions not recognized, so there's some extra traffic that is
NDMP-ish in the capture.
~aaron
On 6/30/06, ronnie sahlberg <ronniesahlberg@gmail.com> wrote:
>
> ok,
>
>
>
> ill check it in in a few hours.
>
> by the way, do you have access to ndmp captures you can share and upload
> to the wiki page?
> we do not have any public sample captures of NDMP yet.
>
>
>
>
> On 6/30/06, Aaron Christensen <aaronmf@gmail.com> wrote:
> >
> > Hi, Ronnie,
> > I initally checked this against the specification for NDMPv2 and v4 to
> > make sure. In going back, I double checked with v2, and then check against
> > v3, v4, and v5. It looks like the error field has been in there all along
> > for NDMP_CONFIG_GET_AUTH_ATTR. I admit, I only have an implementation for
> > NDMPv4, and since the specification for this message is unchanged it seems
> > to me that other versions should be the same implementation-wise.
> >
> > Regards,
> > ~Aaron
> >
> >
> > On 6/29/06, ronnie sahlberg < ronniesahlberg@gmail.com> wrote:
> > >
> > > Can you check ndmp versions 2 to 5 that this is true for all
> > > versions of ndmp?
> > >
> > > if not you have to add a switch statement to manage the difference
> > > between versions.
> > >
> > >
> > >
> > > On 6/30/06, Aaron Christensen <aaronmf@gmail.com> wrote:
> > >
> > > > Added the dissection of a field that wasn't being picked up during
> > > NDMP MD5 authentication.
> > >
> > > The NDMP_CONFIG_GET_AUTH_ATTR message response was using the function
> > > dissect_auth_attr_msg() which dissects an auth_attr struct. However, the
> > > specification includes and error field previous to that struct. Since that
> > > function was being called directly, the error field was being picked up as
> > > part of the auth_attr, and then leaving some extra data at the end.
> > >
> > > I added a new function, dissect_ndmp_config_get_auth_attr_reply(),
> > > which first calls dissect_error() and then dissect_auth_attr_msg(). I
> > > didn't change dissect_auth_attr_msg() because the NDMP_CONNECT_SERVER_AUTH
> > > request uses it directly. After testing it, it appears to be picking things
> > > up correctly, now.
> > >
> > > Regards,
> > > ~Aaron Christensen
> > >
> > > _______________________________________________
> > > Wireshark-dev mailing list
> > > Wireshark-dev@wireshark.org
> > > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> > >
> > >
> > >
> > >
> > >
> >
>
[Attachment #3 (text/html)]
Sure. Done:<br><br><a \
href="http://wiki.wireshark.org/Network_Data_Management_Protocol">http://wiki.wireshark.org/Network_Data_Management_Protocol</a><br><br>A \
couple of images of captured packets (including one that works after the patch) and a \
sample packet capture. The NDMP client/server I was using had some extensions \
not recognized, so there's some extra traffic that is NDMP-ish in the capture. \
<br><br>~aaron<br><br><div><span class="gmail_quote">On 6/30/06, <b \
class="gmail_sendername">ronnie sahlberg</b> <<a \
href="mailto:ronniesahlberg@gmail.com">ronniesahlberg@gmail.com</a>> \
wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> \
<div>ok,<br><br><br><br>ill check it in in a few hours.<br><br>by the \
way, do you have access to ndmp captures you can share and upload to the \
wiki page?<br>we do not have any public sample captures of NDMP yet.</div><div> <span \
class="e" id="q_10c23789ca51ea11_1"><br><br><br><br> <div><span \
class="gmail_quote">On 6/30/06, <b class="gmail_sendername">Aaron Christensen</b> \
<<a href="mailto:aaronmf@gmail.com" target="_blank" onclick="return \
top.js.OpenExtLink(window,event,this)">aaronmf@gmail.com </a>> \
wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div>Hi, Ronnie,<br>I \
initally checked this against the specification for NDMPv2 and v4 to make sure. \
In going back, I double checked with v2, and then check against v3, v4, and v5. \
It looks like the error field has been in there all along for \
NDMP_CONFIG_GET_AUTH_ATTR. I admit, I only have an implementation for NDMPv4, \
and since the specification for this message is unchanged it seems to me that other \
versions should be the same implementation-wise. \
<br><br>Regards,<br></div><div><span>~Aaron</span></div><div><span><br><br><div><span \
class="gmail_quote">On 6/29/06, <b class="gmail_sendername">ronnie sahlberg</b> \
<<a href="mailto:ronniesahlberg@gmail.com" target="_blank" onclick="return \
top.js.OpenExtLink(window,event,this)">
ronniesahlberg@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" \
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; \
padding-left: 1ex;"> <div>Can you check ndmp versions 2 to 5 that this is \
true for all versions of ndmp?<br><br>if not you have to add a switch statement \
to manage the difference between versions.<br><br><br><br><div></div><div><span> \
<span class="gmail_quote">On 6/30/06, <b class="gmail_sendername">Aaron \
Christensen</b> <<a href="mailto:aaronmf@gmail.com" target="_blank" \
onclick="return top.js.OpenExtLink(window,event,this)">aaronmf@gmail.com</a>> \
wrote:</span></span></div><div><blockquote class="gmail_quote" style="border-left: \
1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
</blockquote></div><div><span>
<div>Added the dissection of a field that wasn't being picked up during NDMP MD5 \
authentication.<br><br>The NDMP_CONFIG_GET_AUTH_ATTR message response was using the \
function dissect_auth_attr_msg() which dissects an auth_attr struct. However, \
the specification includes and error field previous to that struct. Since that \
function was being called directly, the error field was being picked up as part \
of the auth_attr, and then leaving some extra data at the end. <br><br>I added a new \
function, dissect_ndmp_config_get_auth_attr_reply(), which first calls \
dissect_error() and then dissect_auth_attr_msg(). I didn't change \
dissect_auth_attr_msg() because the NDMP_CONNECT_SERVER_AUTH request uses it \
directly. After testing it, it appears to be picking things up correctly, now. \
<br><br>Regards,<br></div><div><span>~Aaron Christensen<br>
</span></div><br></span></div><div>_______________________________________________<br>Wireshark-dev \
mailing list<br><a href="mailto:Wireshark-dev@wireshark.org" target="_blank" \
onclick="return top.js.OpenExtLink(window,event,this)">
Wireshark-dev@wireshark.org
</a><br><a href="http://www.wireshark.org/mailman/listinfo/wireshark-dev" \
target="_blank" onclick="return \
top.js.OpenExtLink(window,event,this)">http://www.wireshark.org/mailman/listinfo/wireshark-dev</a><br><br><br><br \
clear="all">
</div><br>
</div></blockquote></div><br>
</span></div></blockquote></div><br>
</span></div></blockquote></div><br>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic