[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-commits
Subject:    [Wireshark-commits] master e768e13: Qt: Fix Follow Stream regression in Conversations dialog
From:       Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date:       2019-09-30 5:45:13
Message-ID: 156982230982.20169.8576253424202849846 () srv3 ! frosun ! ops ! wireshark ! net
[Download RAW message or body]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e768e13479796dba755884941d210153b9823986
                
Submitter: "Alexis La Goutte <alexis.lagoutte@gmail.com>"
Changed: branch: master
Repository: wireshark

Commits:

e768e13 by Peter Wu (peter@lekensteyn.nl):

    Qt: Fix Follow Stream regression in Conversations dialog
    
    The "Follow Stream" button did not have any effect due to:
    
        QObject::connect: No such slot \
MainWindow::openFollowStreamDialog(follow_type_t, guint) in \
/tmp/wireshark/ui/qt/main_window_slots.cpp:3034  QObject::connect:  (sender name:   \
'TrafficTableDialog')  QObject::connect:  (receiver name: 'MainWindow')
    
    Change-Id: If9ecae9a971bdc31358d95af33a8245aa5df5911
    Fixes: v3.1.1rc0-352-g9fff62e2a8 ("Qt, http2: Add Follow HTTP/2 Stream \
functionality")  Reviewed-on: https://code.wireshark.org/review/34653
    Petri-Dish: Peter Wu <peter@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jim Young <jim.young.ws@gmail.com>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
    

Actions performed:

    from  486c6fd   Fix interpretation of BSO field in Type III headers.
     add  e768e13   Qt: Fix Follow Stream regression in Conversations dialog


Summary of changes:
 ui/qt/conversation_dialog.cpp | 3 ++-
 ui/qt/conversation_dialog.h   | 2 +-
 ui/qt/main_window_slots.cpp   | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe


[prev in list] [next in list] [prev in thread] [next in thread]