[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-commits
Subject: [Wireshark-commits] master a0cdb06: Fix shadow variable warnings, fix type error.
From: Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date: 2019-07-30 7:47:25
Message-ID: 156447284148.30487.3483734049979018274 () srv3 ! frosun ! ops ! wireshark ! net
[Download RAW message or body]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a0cdb06abafc596d84baa0c8a14b2971c88ce661
Submitter: "Guy Harris <guy@alum.mit.edu>"
Changed: branch: master
Repository: wireshark
Commits:
a0cdb06 by Guy Harris (guy@alum.mit.edu):
Fix shadow variable warnings, fix type error.
Sadly, index() is still defined to be a function in some UN*Xes, for
backwards compatibility with V7, where the function now known as
strchr() was called index(); pick another name for variables named
"index".
wmem_array_get_count() returns a guint; store its value in a guint.
That also means its return value is never negative.
Change-Id: I357dcda9297f242355ef1ad8d2f1f192a0b5bb5f
Reviewed-on: https://code.wireshark.org/review/34132
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Actions performed:
from 679ae4c Qt: Improve numerus translation in status bar
add a0cdb06 Fix shadow variable warnings, fix type error.
Summary of changes:
epan/tvbuff_lz77huff.c | 38 ++++++++++++++++++--------------------
1 file changed, 18 insertions(+), 20 deletions(-)
___________________________________________________________________________
Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic