[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-commits
Subject:    [Wireshark-commits] master-3.0 576a4a1: proto: fix proto_item_add_bitmask_tree with zero length
From:       Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date:       2019-07-29 20:51:01
Message-ID: 156443345843.11504.6930190992774644819 () srv3 ! frosun ! ops ! wireshark ! net
[Download RAW message or body]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=576a4a165177957abc26b7e1c5fe8d75392ba2b8
                
Submitter: "Peter Wu <peter@lekensteyn.nl>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

576a4a1 by Peter Wu (peter@lekensteyn.nl):

    proto: fix proto_item_add_bitmask_tree with zero length
    
    packet-frame.c calls proto_item_add_bitmask_tree with a zero length, be
    sure not to trigger undefined behavior (right shift by 64). Observed
    with the capture from Bug 15247.
    
    Change-Id: I5b5b7f920a37365295603be7b915f51b39d99faf
    Fixes: v2.1.0rc0-1776-gb9fb2ceb88 ("Add heuristic dissectors for the variable \
part of COTP CR and CC PDUs.")  Reviewed-on: https://code.wireshark.org/review/34108
    Petri-Dish: Peter Wu <peter@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@lekensteyn.nl>
    (cherry picked from commit 78cb716071bfa8a636b9268deea096041293f7de)
    Reviewed-on: https://code.wireshark.org/review/34126
    

Actions performed:

    from  eea6906   doc: document WIRESHARK_CONFIG_DIR
     add  576a4a1   proto: fix proto_item_add_bitmask_tree with zero length


Summary of changes:
 epan/proto.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe


[prev in list] [next in list] [prev in thread] [next in thread]