[prev in list] [next in list] [prev in thread] [next in thread]
List: wireshark-commits
Subject: [Wireshark-commits] master a67082d: IEEE 802.15.4: fix decryption results based on uninitialized dat
From: Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date: 2018-03-30 7:29:17
Message-ID: 152239495126.7870.758739362566881606 () srv3 ! frosun ! ops ! wireshark ! net
[Download RAW message or body]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a67082d35438cd02cf5d75b0c1e8c7410c580ec9
Submitter: Anders Broman (a.broman58@gmail.com)
Changed: branch: master
Repository: wireshark
Commits:
a67082d by Robert Sauter (sauter@locoslab.com):
IEEE 802.15.4: fix decryption results based on uninitialized data
Refactor ieee802154_set_mac_key to return the number of keys set and
only try to decrypt with the alt_key if actually provided
Bug: 14522
Change-Id: I40802dff8c08f7f82b792fb16f5f91aa3b9e20cc
Reviewed-on: https://code.wireshark.org/review/26677
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Actions performed:
from afede5f ZigBee: Do not use value_string_ext for small arrays
adds a67082d IEEE 802.15.4: fix decryption results based on uninitialized data
Summary of changes:
epan/dissectors/packet-ieee802154.c | 19 +++++++++++--------
epan/dissectors/packet-ieee802154.h | 12 ++++++------
epan/dissectors/packet-mle.c | 10 +++++-----
epan/dissectors/packet-mle.h | 3 +--
epan/dissectors/packet-thread.c | 14 +++++++-------
5 files changed, 30 insertions(+), 28 deletions(-)
___________________________________________________________________________
Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic