[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-commits
Subject:    [Wireshark-commits] master 35fed45: Don't bother with CMAKE_C_STANDARD.
From:       Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date:       2018-03-29 6:16:38
Message-ID: 152230419007.32018.14126761470367075158 () srv3 ! frosun ! ops ! wireshark ! net
[Download RAW message or body]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35fed45a831e44e940b123b2ed2a3fbe1b70b21d
Submitter: Roland Knall (rknall@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

35fed45 by Guy Harris (guy@alum.mit.edu):

    Don't bother with CMAKE_C_STANDARD.
    
    It was introduced in CMake 3.1, so, unless we require CMake 3.1 or
    later, we'd have to manually try to enable C99 support on pre-3.1
    releases, so we might as well just do it manually all the time - it's
    not clear that CMAKE_C_STANDARD does it much better, especially give
    that, for example, it wasn't until CMake 3.9 that support for enabling
    C99 support in IBM XL C was added.
    
    Change-Id: I51038b90fd3d8ab5050c5da4441765b19db9091b
    Reviewed-on: https://code.wireshark.org/review/26648
    Reviewed-by: Peter Wu <peter@lekensteyn.nl>
    Petri-Dish: Peter Wu <peter@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@gmail.com>
    

Actions performed:

    from  f3952f6   DOCSIS: Making sure UCD contained in REGRSPMP does not overwrite the REGRSPMP info
    adds  35fed45   Don't bother with CMAKE_C_STANDARD.


Summary of changes:
 CMakeLists.txt | 85 +++++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 54 insertions(+), 31 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]