[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-commits
Subject:    [Wireshark-commits] master 1a949ba: NCP2222: change ncp.nds_return_all_classes filter type from FT_S
From:       Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date:       2015-09-29 21:48:52
Message-ID: 20150929214846.16872.20584 () thud ! wireshark ! org
[Download RAW message or body]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a949ba87bd6f48f666ab203ce509a918f583bc5
Submitter: Michael Mann (mmann78@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

1a949ba by Pascal Quantin (pascal.quantin@gmail.com):

    NCP2222: change ncp.nds_return_all_classes filter type from FT_STRING to FT_UINT32
    
    Otherwise a call to proto_tree_add_uint_format_value will trigger an assert
    
    Bug: 11550
    Change-Id: Ic30b07a424cd94b861cee8999b91154ceeb72469
    Reviewed-on: https://code.wireshark.org/review/10689
    Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
    Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
    Reviewed-by: Michael Mann <mmann78@netscape.net>
    

Actions performed:

    from  4ea7a9a   Qt: Add F5 as shortcut to refresh interfaces
    adds  1a949ba   NCP2222: change ncp.nds_return_all_classes filter type from FT_STRING to FT_UINT32


Summary of changes:
 tools/ncp2222.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]